Use aria-label to avoid radio label double-read#8567
Merged
Conversation
changelog: User-Facing Improvements, Accessibility, Avoid duplicate announcement of radio label text
jmdembe
reviewed
Jun 9, 2023
jmdembe
approved these changes
Jun 9, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9949
🛠 Summary of changes
Updates markup for email languages radio selection to improve how labels are read by screen readers, preventing the label from being read twice when navigating contents (via arrow keys or "Read All" functionality).
📜 Testing Plan
👀 Screenshots
Before:
before.mp4
After:
after.mp4