Skip to content

Comments

LG-8830: Replace RedoDocumentCaptureAction with redirect to hybrid handoff#8557

Merged
soniaconnolly merged 3 commits intomainfrom
dprice-lg-8830-redo-document-capture-take3
Jun 9, 2023
Merged

LG-8830: Replace RedoDocumentCaptureAction with redirect to hybrid handoff#8557
soniaconnolly merged 3 commits intomainfrom
dprice-lg-8830-redo-document-capture-take3

Conversation

@soniaconnolly
Copy link
Contributor

@soniaconnolly soniaconnolly commented Jun 8, 2023

🎫 Ticket

LG-8830

🛠 Summary of changes

Add a redo parameter to hybrid_handoff show, and change the before action to allow redoing hybrid_handoff when it is present. Once this is deployed we can remove RedoDocumentCaptureAction from DocAuthFlow and remove the code.

Similarly replace CancelLinkSentAction on the LinkSent page with a link to hybrid_handoff with redo=true parameter. No longer render _back partial.

📜 Testing Plan

  • Create account, start IdV
  • On HybridHandoff, select Send Link
  • Click the Back link at the bottom of the page
  • Expect to be on HybridHandoff
  • This time, select Upload Photos
  • For DocumentCapture, upload a yaml that causes a barcode read error
  • Continue through to VerifyInfo
  • Expect to see a banner at the top with a link to upload new images
  • Click the link and expect to be on HybridHandoff
  • Go forward with photos or a successful yaml file
  • Expect no banner on VerifyInfo

👀 Screenshots

LinkSent Before:

LinkSent before

LinkSent After:

LinkSent after

soniaconnolly and others added 3 commits June 8, 2023 16:50
handoff.

changelog: Internal, Refactoring, Replace FSM RedoDocumentCaptureAction

Co-authored-by: Douglas Price <douglas.price@gsa.gov>
It no longer renders the shared _back template.
@soniaconnolly soniaconnolly force-pushed the dprice-lg-8830-redo-document-capture-take3 branch from c26e9a1 to a64612d Compare June 8, 2023 23:50
@soniaconnolly soniaconnolly requested a review from a team June 8, 2023 23:53
Copy link
Contributor

@solipet solipet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Went through the steps to test and everything worked as expected.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants