Deploy RC 284 to Production#8503
Merged
mitchellhenke merged 20 commits intostages/prodfrom May 30, 2023
Merged
Conversation
* Add autocomplete attribute to password fields changelog: User-Facing Improvements, Passwords, Improve password autocomplete support * Add preview for PasswordConfirmationComponent * Put input_html in the correct place (field_options)
* Fix spinner button animation for long action text changelog: Bug Fixes, UI Components, Fix appearance of button spinner in specific scenarios * Sync SpinnerButton specs to markup revisions * Bump CodeClimate * Trim all whitespace * Add outline options to SpinnerButton previews Since we explicitly handle outline button as part of the spinner button implementation * Update SpinnerButton markup for React component Revert stylesheet to main application stylesheet, since currently there's not a way to auto-load component stylesheets for components implemented in React * Use String#lstrip instead of String#sub See: https://github.com/18F/identity-idp/pull/8472/files#r1204466631 Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
[skip changelog]
* Remove combined params from mobile upload step url * [skip changelog] --------- Co-authored-by: AmirReavis-Bey <amirreavis-bey@fcoh2j-wyp9w9mv.localdomain>
…ge (#8435) * LG-9816 Edit hint text for ID number and increase input size * LG-9816 Add spaces in fr state_id_number_hint txt * changlog: User-Facing Improvements, In-person proofing, Edit state id number hint text * LG-9816 Restore en.yml section * changelog: User-Facing Improvements, In-person proofing, Edit state id number hint text * LG-9816 fix lint issue * LG-9816 Add grid-col-10 to hint text * LG-9816 Use existing class for breakpoint * LG-9816 remove extra line * LG-9816 Refactor to include html so we can tell screen reader value * LG-9816 Added fr and es translations
* Allow using StepIndicatorConcern w/o IdvSession If the user is not logged in and does not have an `idv_session` available (as is the case in the hybrid document capture flow), this code would raise and the user would get a 500 error. This update makes an assumption that if the user is not properly logged in they are probably not in the gpo or in person flow. [skip changelog] * Update app/controllers/concerns/idv/step_indicator_concern.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Add IdvSession to controllers that need it These controllers previously included IdvSession via StepIndicatorConcern. * Refactor proofing_components being/end block into a method --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
changelog: Bug Fixes, Personal Key, Fix button appearance for "Copy" link
* LG-8440: Install aws-sdk-ruby; create migration for status check field * LG-8440: Start writing job to check enrollment status update messages (wip) * LG-8440: Install mail gem; update job to read email sent via SNS/SQS * LG-8440: Rename job; improve handling for errors and message deletion * LG-8440: Continue refining logic around error logging; break up logic into modules * LG-8440: Split out analytics methods; start writing specs for job * LG-8440: Test and refine error reporting module * LG-8440: Continue writing tests; improve docs and error logic * LG-8440: Continue writing tests * LG-8440: Write test for enrollment pipeline * LG-8440: Fix module imports and default config * LG-8440: Consolidate SQS client calls; update tests * LG-8440: Write spec for SQS batch processor * LG-8440: Format spec file; add method documentation to process_batch * LG-8440: Add test for job; add new config value * LG-8440: Add config keys; rename key; lint fixes * LG-8440: Update analytics params and documentation * changelog: Internal, In-Person Proofing, Ingest in-person enrollment status updates from SQS * LG-8440: Extract batch deletion into separate method * LG-8440: Refactor modules to support dependency injection (WIP) * LG-8440: Move factory methods to job; write tests for factory methods; update job * LG-8440: Fix date logging and test * LG-8440: Increase the AWS HTTP read timeout for SQS client * LG-8440: Update error reporter to use analytics directly * LG-8440: Update to remove analytics factory * Update spec/jobs/in_person/enrollments_ready_for_status_check/enrollment_pipeline_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/jobs/in_person/enrollments_ready_for_status_check/sqs_batch_wrapper.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * LG-9905: Use blank? instead of unless for flag check * LG-9905: Fix conditional and update test to catch issue --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Initial commit with feature flag * Adding controller, view, and route * Casing redirect for upload step * Adding view locals to hybrid handoff template * Adding controller spec * Adding step indicator to show view * Adding initial feature spec Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> changelog: Internal, FSM Removal, Add new controller for hybrid handoff (feature-flagged)
#8486) * Allow configuring shortcodes for international country codes changelog: User-Facing Improvements, Telephony, Allow configuring shortcodes for international country codes * Update lib/telephony/configuration.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> --------- Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Consolidate two factor verification and confirmation behavior changelog: Internal, Two-Factor Authentication, Consolidate two factor verification and confirmation behavior
* Upgrade ViewComponent dependencies changelog: Internal, Dependencies, Update UI component dependencies to latest versions * Password Confirmation: Fix translate in constructor error * Move listen to development+test group Avoid error in build See: https://gsa-tts.slack.com/archives/C0NGESUN5/p1685025108314149
* Increase parallel CI jobs This increases the parallel job count to speed CI. It also adds per-step timing to script lists to help in identifying slow steps. The end result is a mild speedup shaving around 4 minutes off the typical CI run. Further work on breaking down specs could lead better performance. changelog: Internal, CI, Minor speedup * Drop back to less fan out
…e GPO pending status cleared (#8492) We had a bug where users who are in the GPO pending state did not have that state cleared after entering a successful code and going through in-person proofing. This resulted in an error attempting to activate these users profiles when the enrollments background job runs. changelog: Improvements, In-person proofing, A bug in which users who were letter and in-person pending did not have their letter pending status cleared after entering a letter code resulting in the user not being proofed after visiting the post office was fixed.
* Removed async uploads much more carefully changelog: Internal,Background proofing,Remove the JS/TS code for background proofing
* LG-9860: Fix platform authenticator reauthentication redirect changelog: Upcoming Features, Platform Authenticator, Fix redirect for reauthentication during platform authenticator setup * Omit platform parameter if false
… when reading with the arrow keys (#8487) * can I add lang as attribute on label? * add `lang` attribute to inputs * add lang attribute for span again * changelog: Improvements, accessibility, input not reading in correct language
* Cherry-pick design system form control styles changelog: Internal, Performance, Reduce size of application stylesheets in critical path * Add custom LGDS form controls
* Improve one-time code pattern enforcement, prefix handling changelog: User-Facing Improvements, One-Time Code, Improve pattern recognition for one-time code fields * Update one_time_code_input_component_preview.rb * Remove code_length from OTP field render * Avoid escaping Regexp outside JS syntax characters Browsers may log an error otherwise * Re-add uppercase letter support for non-numeric one-time code * Update one_time_code_input_component_spec.rb * Update spec to satisfy code format in wrong code Previously, the form would allow this submission, but now that we're more strict about the format, it'd be caught on presubmission form validation
mdiarra3
approved these changes
May 30, 2023
mdiarra3
approved these changes
May 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features