Conversation
aduth
reviewed
May 25, 2023
Contributor
There was a problem hiding this comment.
We have lang above on line 28 as well. Do we need both?
Contributor
Author
There was a problem hiding this comment.
Line 32 puts the attribute on the element while 28 puts it on the <span> attribute itself. Right now, if a user activates the read-all feature, it will read both the input and the text in the set languages.
The fact that this is happening should be discussed further and that is why I wrote LG-9949. There have been previous discussions on whether or not similar behaviors are priority fixes. So for now, I think we both.
f61957f to
e322fb6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9423
🛠 Summary of changes
This ticket fixes a bug. When a user interacts with the radio buttons with a screen reader, radio buttons are not being read in their correct language. Now, if a user decides to use the arrow keys to navigate through the input elements, they are now read in their set language.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
Pre-requisites:
macOS
Windows
For testing on a virtual machine, follow the README instructions for setting up your testing and development environment
👀 Screenshots
Screen recordings tested using VO with Chrome on macOS and JAWS with Chrome on a Windows virtual environment
Before:
LG-9423.JAWS.before.mov
before.VO.LG-9423.mov
After:
LG-9423.VO.after.mov
after.LG-9423.JAWS.mov
Notes