Skip to content

LG-9423: Radio buttons are not read correctly by assistive technology when reading with the arrow keys#8487

Merged
jmdembe merged 5 commits intomainfrom
LG-9423-radio-button-lang-announcement
May 26, 2023
Merged

LG-9423: Radio buttons are not read correctly by assistive technology when reading with the arrow keys#8487
jmdembe merged 5 commits intomainfrom
LG-9423-radio-button-lang-announcement

Conversation

@jmdembe
Copy link
Copy Markdown
Contributor

@jmdembe jmdembe commented May 25, 2023

🎫 Ticket

LG-9423

🛠 Summary of changes

This ticket fixes a bug. When a user interacts with the radio buttons with a screen reader, radio buttons are not being read in their correct language. Now, if a user decides to use the arrow keys to navigate through the input elements, they are now read in their set language.

📜 Testing Plan

Provide a checklist of steps to confirm the changes.

Pre-requisites:

macOS

  • VoiceOver
  • Chrome
  • Safari

Windows

  • JAWS
  • Chrome
  • Firefox (optional)

For testing on a virtual machine, follow the README instructions for setting up your testing and development environment

👀 Screenshots

Screen recordings tested using VO with Chrome on macOS and JAWS with Chrome on a Windows virtual environment

Before:
LG-9423.JAWS.before.mov
before.VO.LG-9423.mov
After:
LG-9423.VO.after.mov
after.LG-9423.JAWS.mov

Notes

  • The ticket briefly mentions that an expected behavior should be "Language is read once in the native voice." Since this AC was not a part of the original description, this will be discussed in LG-9949.
  • It may be worth looking through other form interactive elements to see if they also have the same current behavior.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have lang above on line 28 as well. Do we need both?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 32 puts the attribute on the element while 28 puts it on the <span> attribute itself. Right now, if a user activates the read-all feature, it will read both the input and the text in the set languages.

The fact that this is happening should be discussed further and that is why I wrote LG-9949. There have been previous discussions on whether or not similar behaviors are priority fixes. So for now, I think we both.

Copy link
Copy Markdown
Contributor

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jmdembe jmdembe force-pushed the LG-9423-radio-button-lang-announcement branch from f61957f to e322fb6 Compare May 26, 2023 13:17
@jmdembe jmdembe merged commit b121550 into main May 26, 2023
@jmdembe jmdembe deleted the LG-9423-radio-button-lang-announcement branch May 26, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants