Merged
Conversation
mitchellhenke
approved these changes
May 17, 2023
Merged
aduth
added a commit
that referenced
this pull request
May 25, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This reverts the changes that migrated from Sprockets to Propshaft (#8387, #8402, #8409) due to issues observed in deployed environments.
Specifically, there seems to be some unpredictable behavior related to our use of CDNs via
asset_host, where recent changes in Propshaft result in assets resolving to invalid paths (e.g./assets/login.gov/assets/angle-arrow-up-white-[digest].svgvs. expected/assets/angle-arrow-up-white-[digest].svg). The idea with reverting is to allow for this behavior to stabilize in Propshaft.This does preserve some of the work in the reverted pull requests, notably spec revisions and other improvements which are valuable regardless of Sprockets vs. Prosphaft. These are reflected in commits 857112c, 080636a, and 76d2268.
Related Slack discussions:
Related upstream issues / commits:
📜 Testing Plan