Allow using StepIndicatorConcern w/o IdvSession#8480
Merged
Conversation
If the user is not logged in and does not have an `idv_session` available (as is the case in the hybrid document capture flow), this code would raise and the user would get a 500 error. This update makes an assumption that if the user is not properly logged in they are probably not in the gpo or in person flow. [skip changelog]
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
These controllers previously included IdvSession via StepIndicatorConcern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user is not logged in and does not have an
idv_sessionavailable (as is the case in the hybrid document capture flow),StepIndicatorConcernwould raise. This prevented us from adding the step indicator to some of the IdV error screens as shown in Figmas.This updates
StepIndicatorConcernto:current_userbeingnilidv_sessionbeing unavailable ornilIdvSessionIf the user is not logged in or an
idv_sessionis not available, the concern will assume the user is not in the in-person or gpo flows.