Conversation
|
Based on spec failures, need to fix |
aaaa99b to
ce78d50
Compare
Fixed in rebased ce78d50. I'm noticing a strange (seemingly harmless) Rack lint error when viewing component preview pages (example page): It's followed by a 500 for a One of the changes in the Lookbook 2.0 upgrade related to |
changelog: Internal, Dependencies, Update UI component dependencies to latest versions
ce78d50 to
29e3a17
Compare
I tried again after merging #8457 and it still happens. Troubleshooting more, it seems to be related to ActionCable responding with a See: rails/rails#26179 |
Avoid error in build See: https://gsa-tts.slack.com/archives/C0NGESUN5/p1685025108314149
🛠 Summary of changes
Upgrades ViewComponent and Lookbook to their latest respective versions, both of which are major upgrades:
Notable breaking changes encountered:
controllerandrequestwere removed from spec helpers, and were updated to equivalentvc_test_controllerandvc_test_request.with_prefix📜 Testing Plan
rspec