Skip to content

LG-9709: Add autocomplete attribute to password fields#8466

Merged
aduth merged 3 commits intomainfrom
aduth-password-autocomplete
May 24, 2023
Merged

LG-9709: Add autocomplete attribute to password fields#8466
aduth merged 3 commits intomainfrom
aduth-password-autocomplete

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 23, 2023

🎫 Ticket

LG-9709

🛠 Summary of changes

Adds autocomplete attributes to every password field in the application, set to either new-password or current-password based on context of the field's usage.

Related resources:

The practical impact of this can be improved autofill options offered by the browser. See screenshots for an example.

📜 Testing Plan

  • Verify that autocomplete still works as expected in your browser for affected password fields.

👀 Screenshots

Example showing effect of [autocomplete=new-password] in Chrome:

Before After
Screen Shot 2023-05-23 at 1 31 20 PM Screen Shot 2023-05-23 at 1 31 31 PM

aduth added 2 commits May 23, 2023 13:49
changelog: User-Facing Improvements, Passwords, Improve password autocomplete support
@@ -0,0 +1,3 @@
lg-password-confirmation {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default display of custom elements is inline, which can cause some unexpected layout if not otherwise accounted for. This was previously fine in the account creation flow because sibling elements were block elements so it appeared standalone, but usage in the preview page was broken without.

Before After
image image

Copy link
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aduth aduth merged commit 74cab8a into main May 24, 2023
@aduth aduth deleted the aduth-password-autocomplete branch May 24, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants