LG-9709: Add autocomplete attribute to password fields#8466
Merged
Conversation
changelog: User-Facing Improvements, Passwords, Improve password autocomplete support
aduth
commented
May 23, 2023
| @@ -0,0 +1,3 @@ | |||
| lg-password-confirmation { | |||
Contributor
Author
There was a problem hiding this comment.
Default display of custom elements is inline, which can cause some unexpected layout if not otherwise accounted for. This was previously fine in the account creation flow because sibling elements were block elements so it appeared standalone, but usage in the preview page was broken without.
| Before | After |
|---|---|
![]() |
![]() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


🎫 Ticket
LG-9709
🛠 Summary of changes
Adds
autocompleteattributes to every password field in the application, set to eithernew-passwordorcurrent-passwordbased on context of the field's usage.Related resources:
The practical impact of this can be improved autofill options offered by the browser. See screenshots for an example.
📜 Testing Plan
👀 Screenshots
Example showing effect of
[autocomplete=new-password]in Chrome: