Skip to content

Fix mobile unstyled appearance for clipboard button#8484

Merged
aduth merged 1 commit intomainfrom
aduth-clipboard-button-unstyled
May 25, 2023
Merged

Fix mobile unstyled appearance for clipboard button#8484
aduth merged 1 commit intomainfrom
aduth-clipboard-button-unstyled

Conversation

@aduth
Copy link
Contributor

@aduth aduth commented May 25, 2023

🛠 Summary of changes

Fixes a bug where the "Copy" button appears incorrect on the Personal Key confirmation screen at small viewport sizes, regressed in #8307 due to a workaround introduced to resolve an upstream issue with button display at small viewport sizes.

The workaround caused all buttons to appear as display: block, but since an unstyled button is expected to appear as display: inline (source), these should be excluded from the workaround.

📜 Testing Plan

  1. Go to http://localhost:3000
  2. Sign in or create an account
  3. Go to http://localhost:3000/verify
  4. Complete identity verification up to personal key screen
  5. If on desktop, use devtools screen size emulator to emulate a mobile phone viewport width
  6. Observe that "Copy" link appears inline

👀 Screenshots

Before After
localhost_3000_verify_personal_key(iPhone XR) (1) localhost_3000_verify_personal_key(iPhone XR)

changelog: Bug Fixes, Personal Key, Fix button appearance for "Copy" link
@aduth aduth merged commit 45431f0 into main May 25, 2023
@aduth aduth deleted the aduth-clipboard-button-unstyled branch May 25, 2023 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants