Skip to content

LG-9860: Fix platform authenticator reauthentication redirect#8490

Merged
aduth merged 2 commits intomainfrom
aduth-lg-9860-reauthn-platform-auth
May 26, 2023
Merged

LG-9860: Fix platform authenticator reauthentication redirect#8490
aduth merged 2 commits intomainfrom
aduth-lg-9860-reauthn-platform-auth

Conversation

@aduth
Copy link
Copy Markdown
Contributor

@aduth aduth commented May 26, 2023

🎫 Ticket

LG-9860

🛠 Summary of changes

Fixes an issue where a user who is prompted for reauthentication after submitting platform authenticator setup will be returned to the Security Key setup screen after reauthentication. With these changes, they'll be correctly redirected back to the Face and Touch Unlock setup screen.

📜 Testing Plan

Recommend setting a very low reauthentication window in config/application.yml to facilitate testing:

reauthn_window: 20
  1. Go to http://localhost:3000/
  2. Sign in to an existing account or create an account and then sign in
  3. Click "Add Face or Touch Unlock"
  4. On the "Use your device" screen, wait 2 minutes, or the amount of seconds for reauthn_window if configured
  5. Enter a nickname
  6. Click "Continue" and complete the browser prompts
  7. At this point, you should be prompted for MFA "reauthentication"
  8. Complete the reauthentication

Before: You are redirected to set up Security Key after reauthentication
After: You are redirected to set up Face or Touch Unlock after reauthentication

changelog: Upcoming Features, Platform Authenticator, Fix redirect for reauthentication during platform authenticator setup
@aduth aduth requested a review from a team May 26, 2023 13:30
Copy link
Copy Markdown
Contributor

@zachmargolis zachmargolis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@jmdembe jmdembe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything LGTM

@aduth aduth merged commit ff834ff into main May 26, 2023
@aduth aduth deleted the aduth-lg-9860-reauthn-platform-auth branch May 26, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants