Reintroduce Propshaft as replacement for Sprockets#8457
Merged
Conversation
zachmargolis
approved these changes
May 23, 2023
Comment on lines
-14
to
-16
| config.assets.compile = false | ||
| config.assets.digest = true | ||
| config.assets.gzip = false |
Contributor
There was a problem hiding this comment.
do these options no longer exist? or are they the new defaults?
Contributor
Author
There was a problem hiding this comment.
They no longer exist.
I also came across them when looking through the Propshaft source, commented as being deprecated:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Replaces Sprockets with Propshaft for managing the asset pipeline.
This is a retry of #8387, which was reverted in #8412 due to issues observed in deployed environments.
The key change here is in 1474ff0. By removing the configuration of
asset_host, it's hoped to avoid issues which lead to the use of an inaccurate URL prefix in the published version of the Propshaft gem. Theasset_hostconfiguration is not necessary because (a) our CDN is now configured to serve from the same host as the IdP domain, and (b) Propshaft will still generate root-relative paths (not absolute paths) without the configuration.📜 Testing Plan
(Further testing will be conducted in deployed environments once merged)