Deploy RC 269 to Production#8146
Merged
mitchellhenke merged 25 commits intostages/prodfrom Apr 6, 2023
Merged
Conversation
* Add current_step option to idv/shared/error Allow rendering an error screen with a step indicator * Update idv phone warning screen - EN only for now - Not wired in to controller, just view spec passing * Wire up PhoneErrorsController::warning Mit tësts! * Update feature specs * Split explanation + how long it takes * Add incomplete ES/FR translations Coupla keys missing, will follow up * Store international_code in session when trying phone # Want this for rendering purposes on the warning page. * Update attempts remaining copy Untranslated for now * Add missing translations * First draft of phone rate limited screen English only, tests not updated yet * Remove unneeded shared example There was only 1 use, so it's not really shared anymore? * Update "max attempts" shared examples * Remove unused i18n key * Add es/fr translations for rate limited screen * Update spec for phone_errors/failure.html.erb - More tests around GPO content - Fix ref to i18n key * Add more feature specs for phone rate limited screen * Fix Spanish translation left in French YAML * changelog: User-Facing Improvements, Identity verification, Improve error messaging around phone verification failure and highlight alternate paths. * Use ButtonComponent rather than button_or_link_to * button_or_link_to -> ButtonComponent * Simplify margin css classes
changelog: Internal, Caching, Use ActiveSupport cache version 7.0
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
* saml_2022 -> saml_2023; remove saml_2021 stuff * changelog: Internal, SAML, remove saml2021 references (identity-devops#5739) * update example cert files in config/artifacts.example/local/ - remove the old saml2021 .crt and .key.enc files as they're no longer used/valid - change saml2023 .crt and .key.enc to actual files (vs. symlinks), newly created with openssl req -newkey (etc.) changelog: Internal, SAML, remove saml2021 references (identity-devops#5739) * Update specs to 2023 * Replace auth2022 Command: git grep -l auth2022 -- spec | xargs perl -p -i -e 's/auth2022/auth2023/g' -- * Replace logout2022 git grep -l logout2022 -- spec | xargs perl -p -i -e 's/logout2022/logout2023/g' -- * Update authpost2022 git grep -l authpost2022 -- spec | xargs perl -p -i -e 's/authpost2022/authpost2023/g' * Update one last spec --------- Co-authored-by: Zach Margolis <zachary.margolis@gsa.gov>
* Fix link to help center Link "Learn more about what phone number to use" to https://login.gov/help/verify-your-identity/phone-number/ [skip changelog] * Fix size of "Verify by mail " button
…tion (#8123) Combine the versions of confirm_document_capture_complete in IdvStepConcern (used by SsnController) and in AddressController. This will make it easier to continue updating that method as we continue adding functionality to DocumentCaptureController. Added method pii_from_doc to IdvStepConcern pii is no longer an instance variable and no longer memoized in SsnController and AddressController The long term plan is to move all the step-related before actions and methods to IdvStepConcern Move flow_session and flow_path to IdvStepConcern changelog: Internal, Flow State Machine replacement, combine similar before actions --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>
changelog: Internal, Attempts API, Batch Job improvements
* re-add saml2021* files to AppArtifacts.setup, for now * changelog: Internal, SAML, re-add saml2021 references (identity-devops#5739) * re-add saml2021 files to config/artifacts.example/local/ changelog: Internal, SAML, remove saml2021 references (identity-devops#5739)
* Use Rack::Session methods when calling redis-session-store changelog: Internal, Session Management, Use Rack::Session methods when calling redis-session-store * Update app/services/out_of_band_session_accessor.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/out_of_band_session_accessor.rb --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Change a few links that look like buttons into buttons add link role to a button that is effectively a link * changelog: User-Facing Improvements, In-person proofing, Make IPP buttons and links into what they look like * Remove left over comment * Fix JS errors, replace click_link with click_button
changelog: Internal, Error, Update list of ignored errors
* add fraud_review_eligible? to user model review_eligible? was moved from the proofing component to the user model. Instead of checking the proofing_component's verified_at field we will check the user's profile to determine if they are within the 30 day time frame * change user factory to use new verified_at * remove old review eligible from proofing component * add changelog changelog: Internal, IdV Fraud, Place fraud_review_eligible in user model * add guard for fraud_review_eligible
Prepare for turning on DocumentCaptureController feature flag. [skip changelog]
* Add idv_available config && feature Tie feature to vendor availability as well as config. * Add "IDV Unavailable" view * Add Idv::UnavailableController * Redirect to IDV unavailable page from reg When incoming request requires identity verification, but identity verification is not available, error out early rather than forcing user to create an account first. * Remove unneeded redirect from DocAuthController If IDV is unavailable, this controller will not get called (see routes.rb) * Refactor OutageStatus - We don't actually pass any args in the constructor anymore, so remove them - Remove code paths that rely on values set by those constructor args - Remove unused translations * Update outage feature spec When unavailable, routes inside IDV will not have their path change, but _will_ display an error message. * changelog: User-Facing Improvements, Identity verification, Provide a more helpful and detailed error message when identity verification is unavailable. * Update spec/controllers/idv/unavailable_controller_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Update spec/controllers/idv/unavailable_controller_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Update spec/controllers/idv/unavailable_controller_spec.rb Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov> * Adjust order of args to AnalyticsEvents::vendor_outage * Don't call OutageStatus.new twice * Remove tests for partial_outage support We don't do this anymore. * Move status page link into new paragraph work around weird braking associated with external link's `display: inline-block` in USWDS 2 --------- Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Stop writing data to reports.log (LG-9415) changelog: Internal, Reporting, Remove unused data logging
changelog: Internal, Code Quality, Remove unused code
- Uses artifact from 69071c2 changelog: Internal, CI, Update knapsack report for spec timing
* Adding initial db migrations for fraud timestamp fields * Updating Profile model methods to use fraud timestamp columns * Add Profile#fraud_rejection? and #fraud_review_at? * Add references to fraud_rejection_at in specs * Use new timestamp columns in profile_spec Co-authored-by: Alex Bradley <alexander.bradley@gsa.gov> Co-authored-by: John Maxwell <john.maxwell@gsa.gov> Co-authored-by: John Skinner <john.skinner@gsa.gov> Co-authored-by: Amir Reavis-Bey <amir.reavis-bey@gsa.gov> Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
* Fixed phone number throttling test This test failed because it sometimes said '9 minutes' instead of '10 minutes' We removed `freeze_time`, and changed the test to just check for one of the two possibilities. We don't understand why `freeze_time` wasn't working, but it was simple enough to fix the problem without it.
* add issuing state dropdown and feature test * display issuing state on verify info page * changelog: Upcoming Features, In-person proofing, Collect issuing state on state id page * correct spec expectation * fix issuing state dropdown to link to state_id_jurisdiction * display correct issuing state on verify page * fix pii attributes comments * add state_id_state to encryptor * respond to feedback
* Update sp-user-counts-report to count users as either IAL1 or IAL2 * Update sp-active-user-counts to count users as either IAL1 and IAL2, not both * Switch to nil issuer instead of LOGIN_ALL - Minimize chances of a colliding with actual issuer in the future changelog: Internal, Reporting, Add total count acros all SP to user reports
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal
Upcoming Features