Refactor the IdV step concern to no longer check for an applicant#7840
Merged
Refactor the IdV step concern to no longer check for an applicant#7840
Conversation
Prior to the introduction of the flow state machine, the "applicant" value in the IdV session was created when the proofing process was started. After the introduction of the FSM the applicant was created once the FSM flow was complete. The IdvStepConcern is intended to route users to the correct step based on the state of proofing. Currently it is empty because the Flow State Machine primarily handles this logic. There is a desire to re-introduce the logic to route users to the correct step to this concern. The IdvStepConcern has a before action to verify that proofing has started. It does that by checking for the applicant which, as described above, does not make sense in the post-FSM world. This commit removes that before action and adds it explicitly to controllers that require an applicant to function. changelog: Improvements, Rails controller management, A before action that was used to identify if a user has started proofing was removed from a concern and explicitly called in individual controllers that depended on that before action. The logic in that before action was superceded by the flow state machine.
jmhooper
commented
Feb 15, 2023
| end | ||
| end | ||
|
|
||
| describe '#confirm_idv_session_started' do |
Contributor
Author
There was a problem hiding this comment.
These tests don't make sense in the post-FSM world as described in the pull request description. I added a test to the phone controller spec to test the equivalent logic. The review controller already had a matching test.
soniaconnolly
approved these changes
Feb 15, 2023
Contributor
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM! I pulled this down and tried jumping to the phone and review controllers from the doc_auth flow and it stayed on the verify_info page as desired.
|
|
||
| def confirm_idv_session_started | ||
| def confirm_idv_applicant_created | ||
| redirect_to idv_verify_info_url if idv_session.applicant.blank? |
Contributor
There was a problem hiding this comment.
Are we leaving the issue of the hard-coded doc_auth verify redirect for a separate PR? I checked the flow, and it redirects to verify/doc_auth/document_capture. https://cm-jira.usa.gov/browse/LG-8983
Contributor
Author
There was a problem hiding this comment.
I would like to leave that to a separate PR
Merged
tomas-nava
pushed a commit
that referenced
this pull request
Apr 3, 2023
and remove redundant confirm_two_factor_authenticate (see #8082)
tomas-nava
pushed a commit
that referenced
this pull request
Apr 4, 2023
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to the introduction of the flow state machine, the "applicant" value in the IdV session was created when the proofing process was started. After the introduction of the FSM the applicant was created once the FSM flow was complete.
The IdvStepConcern is intended to route users to the correct step based on the state of proofing. Currently it is empty because the Flow State Machine primarily handles this logic. There is a desire to re-introduce the logic to route users to the correct step to this concern.
The IdvStepConcern has a before action to verify that proofing has started. It does that by checking for the applicant which, as described above, does not make sense in the post-FSM world. This commit removes that before action and adds it explicitly to controllers that require an applicant to function.