Merged
Conversation
review_eligible? was moved from the proofing component to the user model. Instead of checking the proofing_component's verified_at field we will check the user's profile to determine if they are within the 30 day time frame
changelog: Internal, IdV Fraud, Place fraud_review_eligible in user model
mitchellhenke
pushed a commit
that referenced
this pull request
Apr 7, 2023
* add fraud_review_eligible? to user model review_eligible? was moved from the proofing component to the user model. Instead of checking the proofing_component's verified_at field we will check the user's profile to determine if they are within the 30 day time frame * change user factory to use new verified_at * remove old review eligible from proofing component * add changelog changelog: Internal, IdV Fraud, Place fraud_review_eligible in user model * add guard for fraud_review_eligible
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
* add fraud_review_eligible? to user model review_eligible? was moved from the proofing component to the user model. Instead of checking the proofing_component's verified_at field we will check the user's profile to determine if they are within the 30 day time frame * change user factory to use new verified_at * remove old review eligible from proofing component * add changelog changelog: Internal, IdV Fraud, Place fraud_review_eligible in user model * add guard for fraud_review_eligible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9411
🛠 Summary of changes
The old way to check if a profile was fraud_review_eligible was to use the proofing component. This method is now moved to the user model and checks if a user's fraud review profile has a verified_at date.