LG-8908: Add USPS document check to ProofingComponent when enrollment is created#8113
Conversation
changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine
There was a problem hiding this comment.
Tried this out locally, ran into issues. I did see the correct Step Indicator!
- Probably unrelated to this PR: I used a yaml file to get an image resolution error to get into In Person proofing. Then I entered a Puerto Rico address, and said my residential address is different from my ID. I was curious if I would see any Puerto Rico hints, which I didn't on the address entry page. I went to Update Address from VerifyInfo, and saw a New York address that isn't in the yaml file I used. Not sure where that came from! If I click on Back, I still see the Puerto Rico address I entered on the VerifyInfo page.
- Possibly related to whatever went wrong above, when I clicked Continue on the VerifyInfo page, I got an exception. undefined method `log_irs_tmx_fraud_check_event' for #Idv::InPerson::VerifyInfoController:0x0000000003ff48 on verify_info_concern.rb:224
and remove redundant confirm_two_factor_authenticate (see #8082)
and fix links to update pages
This is fixed in 51db501 (although I couldn't reproduce the error where you saw a different address than the one you entered)
This is fixed in c2e02b7 |
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
LGTM, with a comment on possible code cleanup. I ran this and it worked as expected with the correct step indicator on the VerifyInfo step.
Also noting possible follow-on work to bring in threatmetrix specs from remote VerifyInfoController feature specs, or possibly create a separate spec/example file for the shared VerifyInfoConcern.
| analytics.idv_proofing_resolution_result_missing | ||
| flash.now[:error] = I18n.t('idv.failure.timeout') | ||
| render 'idv/verify_info/show' | ||
| render 'idv/in_person/verify_info/show' |
There was a problem hiding this comment.
I had to change this because I was using the shared view, but you might be able to use render :show here and on line 146, and then you might be able to use the shared process_async_state in VerifyInfoConcern if they haven't diverged anywhere else.
There was a problem hiding this comment.
ohh, great catch, thank you. I moved the method into the concern in 7ddff6d
There was a problem hiding this comment.
Looks good! Tried out the flow and everything works.
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
2 participants
🎫 Ticket
Related to LG-8908, follow-up to #7854
🛠 Summary of changes
Add the USPS document check to the ProofingComponent when the enrollment is created in the
Idv::InPerson::UspsLocationsControllerinstead of when the verify page is submitted.This value in the ProofingComponent serves for record keeping and sometimes to determine whether the user is in the process of enrolling in in-person proofing.
The immediate reason for moving it is so that the new
Idv::InPerson::VerifyInfoControllershows the correct steps in its step indicator.📜 Testing Plan
in_person_verify_info_controller_enabledfeature flag to true