Combine two versions of confirm_document_capture_complete before action#8123
Merged
soniaconnolly merged 5 commits intomainfrom Apr 4, 2023
Merged
Combine two versions of confirm_document_capture_complete before action#8123soniaconnolly merged 5 commits intomainfrom
confirm_document_capture_complete before action#8123soniaconnolly merged 5 commits intomainfrom
Conversation
Co-authored-by: Sonia Connolly <sonia.connolly@gsa.gov>
Move flow_session and flow_path to IdvStepConcern changelog: Internal, Flow State Machine replacement, combine similar before actions
aduth
approved these changes
Apr 4, 2023
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
One small comment, but otherwise LGTM 👍
Comment on lines
27
to
28
| flow_path = flow_session&.[](:flow_path) | ||
|
|
Contributor
There was a problem hiding this comment.
Should we remove this line if it's now a method above?
Also, do we need the nil-safe access in the method above? I notice we have it here and in pii_from_doc.
Suggested change
| flow_path = flow_session&.[](:flow_path) |
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks. We do need the nil protection in case someone jumps to the /verify/ssn step without a flow_session - we were seeing 500s in prod, so we added that. I took this line out and added nil protection in #flow_path.
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
…tion (#8123) Combine the versions of confirm_document_capture_complete in IdvStepConcern (used by SsnController) and in AddressController. This will make it easier to continue updating that method as we continue adding functionality to DocumentCaptureController. Added method pii_from_doc to IdvStepConcern pii is no longer an instance variable and no longer memoized in SsnController and AddressController The long term plan is to move all the step-related before actions and methods to IdvStepConcern Move flow_session and flow_path to IdvStepConcern changelog: Internal, Flow State Machine replacement, combine similar before actions --------- Co-authored-by: Douglas Price <douglas.price@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
This started as part of LG-9335, but there are complications with using idv_session in the FSM steps, so that needs to wait until the FSM extraction is complete. Meanwhile, combine the versions of
confirm_document_capture_completein IdvStepConcern (used by SsnController) and in AddressController. This will make it easier to continue updating that method as we continue adding functionality to DocumentCaptureController.Notes:
pii_from_docto IdvStepConcern📜 Testing Plan
/verify/verify/ssnand/verify/address