Use Rack::Session methods when calling redis-session-store#8132
Merged
mitchellhenke merged 3 commits intomainfrom Apr 5, 2023
Merged
Use Rack::Session methods when calling redis-session-store#8132mitchellhenke merged 3 commits intomainfrom
mitchellhenke merged 3 commits intomainfrom
Conversation
changelog: Internal, Session Management, Use Rack::Session methods when calling redis-session-store
zachmargolis
reviewed
Apr 4, 2023
|
|
||
| def destroy | ||
| session_store.send(:destroy_session_from_sid, session_uuid, drop: true) | ||
| session_store.send(:delete_session, {}, Rack::Session::SessionId.new(session_uuid), drop: true) |
Contributor
There was a problem hiding this comment.
😭 it's a bummer these are still private methods
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
commented
Apr 5, 2023
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
* Use Rack::Session methods when calling redis-session-store changelog: Internal, Session Management, Use Rack::Session methods when calling redis-session-store * Update app/services/out_of_band_session_accessor.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/out_of_band_session_accessor.rb --------- Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Rack::Session has a defined interface, but we use some of the internal
redis-session-storemethods. I'm working on a bit of an internal refactor of our redis-session-store fork and this PR is a precursor to realizing some of those changes.