Merged
Conversation
In a post-FSM world we want all the logic about redirects between steps to be in IdvStepConcern. Include this method in the pattern, and include IdvStepConcern in SsnController. Also remove redundant calls to `confirm_two_factor_authenticated` before action since it is included by IdvStepConcern. changelog: Internal, Identity Verification, Refactor code that moves between steps
…tep_needed Note that in_person/verify_info_controller has its own implementation which was also renamed.
Note that AddressController has its own slightly different implementation of this method.
including in AddressController
solipet
approved these changes
Mar 28, 2023
| include StepUtilitiesConcern | ||
| include Steps::ThreatMetrixStepHelper | ||
|
|
||
| before_action :confirm_two_factor_authenticated |
Contributor
There was a problem hiding this comment.
Given that this method is defined in IdvSession, but auto-included as a before action in IdvStepConcern (which in turn includes IdvSession), should IdvSession be responsible for auto-including this before action?
Contributor
Author
There was a problem hiding this comment.
This is worth looking into as a separate cleanup. IdvSession is included in something like 20 controllers, so changing its included actions will take some research and care.
Merged
tomas-nava
pushed a commit
that referenced
this pull request
Apr 3, 2023
and remove redundant confirm_two_factor_authenticate (see #8082)
tomas-nava
pushed a commit
that referenced
this pull request
Apr 4, 2023
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
jc-gsa
pushed a commit
that referenced
this pull request
Apr 19, 2023
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-9099
🛠 Summary of changes
Refactoring PR, app behavior should be unchanged. The behavior change for this ticket will go into
confirm_document_capture_step_completeto redirect back from the SSN controller to the DocumentCaptureController for desktop flow when the feature flag is enabled.This PR might be easier to review by individual commits.
Move and rename two methods from StepUtilitiesConcern to IdvStepConcern, since it is the new place to put before action methods that control ordering of identity verification steps outside the FSM.
confirm_pii_from_doctoconfirm_document_capture_completeconfirm_profile_not_already_confirmedtoconfirm_verify_info_step_neededI discussed these changes with @jmhooper before he left on vacation.
📜 Testing Plan