LG-8932: Fix check for state vs residential address; update test

[NavaTim]

🎫 Ticket

LG-8932

🛠 Summary of changes

• Fix check for state vs residential address
  • Expected boolean type, was actually string type

Also see: #8098

📜 Testing Plan

• Enable feature flag in_person_capture_secondary_id_enabled
• Complete in in-person proofing process up to the state ID form
• Complete state ID form, indicating that the residential address differs from the ID
• Complete the following residential address form with a different address
• Complete the remainder of the in-person proofing process
• Verify with USPS that they received the state ID address

[JackRyan1989]

@NavaTim I assume the testing plan is for local development? Can you help me with the last step: Verify with USPS that they received the state ID address?

[NavaTim]

@NavaTim I assume the testing plan is for local development? Can you help me with the last step: Verify with USPS that they received the state ID address?

@JackRyan1989 For local development, you'll likely need to print out the values (p/puts) when they're sent in app/services/usps_in_person_proofing/enrollment_helper.rb or a similar location.

[JackRyan1989]

LGTM!

[eileen-nava]

I reviewed this and confirmed that the state id address is sent to USPS, which is good. 👍🏻 I'm not sure if you want to make the state_id_jurisdiction change here or in another PR. Also, just a heads-up that I didn't look at the CI's failing tests, so I can't speak to those.