LG-8749: IDV TMX Fraud check event tracking#7924
Conversation
changelog: Internal, Attempts API, Track additional TMX fraud check event
|
|
||
| function MockDeviceProfilingOptions() { | ||
| const [selectedValue, setSelectedValue] = useState(''); | ||
| const [selectedValue, setSelectedValue] = useState('pass'); |
There was a problem hiding this comment.
Setting the default selected value as a pass because it was missed in #7892 PR for LG-8985 “Make Pass the default option for a mock”.
| "request_result":"fail_invalid_parameter", | ||
| "review_status":"REVIEW_STATUS" | ||
| "review_status":"REVIEW_STATUS", | ||
| "tmx_summary_reason_code": ["Identity_Negative_History"] |
There was a problem hiding this comment.
did we get this from checking production logs?
There was a problem hiding this comment.
Yes, I checked the production logs and also from LN we have a lot of others as well but I just mock this only.
There was a problem hiding this comment.
This could be a constant in DocAuthHelper, SAMPLE_TMX_SUMMARY_REASON_CODE or something like that. Along with GOOD_SSN, etc. Since it's used in 3 tests (so far). You might still have to have the explicit string in the fixtures.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
soniaconnolly
left a comment
soniaconnolly
left a comment
There was a problem hiding this comment.
Overall looks good! A couple of suggestions for sharing test code in doc_auth_helper.rb, and a query to make sure we're all on the same page about what happens for No Result.
| let(:review_status) { 'no_result' } | ||
|
|
||
| it 'it logs IRS idv_tmx_fraud_check event' do | ||
| expect(@irs_attempts_api_tracker).to receive(:idv_tmx_fraud_check).with( | ||
| success: false, | ||
| failure_reason: expected_failure_reason, | ||
| ) |
There was a problem hiding this comment.
@jmhooper is this consistent with what we want for Threatmetrix no result? It's treating it as a failure.
| "request_result":"fail_invalid_parameter", | ||
| "review_status":"REVIEW_STATUS" | ||
| "review_status":"REVIEW_STATUS", | ||
| "tmx_summary_reason_code": ["Identity_Negative_History"] |
There was a problem hiding this comment.
This could be a constant in DocAuthHelper, SAMPLE_TMX_SUMMARY_REASON_CODE or something like that. Along with GOOD_SSN, etc. Since it's used in 3 tests (so far). You might still have to have the explicit string in the fixtures.
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
… is created (#8113) * add usps doc check to proofing component earlier changelog: Internal, refactor, in-person VerifyInfoController outside Flow State Machine * include Steps::ThreadMetricStepHelper (see #7924) * replace IdvSession with IdvStepConcern (see #7840) and remove redundant confirm_two_factor_authenticate (see #8082) * give in-person verify info controller its own view and fix links to update pages * move process_async_state into the concern
3 participants
changelog: Internal, Attempts API, Track additional TMX fraud check event