Deploy RC 225 to Production#7308
Merged
mitchellhenke merged 18 commits intostages/prodfrom Nov 7, 2022
Merged
Conversation
* Update Spanish label for "One-time code" field
* Update language on "Enter your security code"
Update language on OTP entry screen to reflect user testing results ("one-time code" rather than "security code").
For LG-7177
[skip changelog]
**Why**: - Adding the configuration parameters `redis_pool_size` and `redis_throttle_pool_size` allows us to limit, or increase, the number of connections to our redis instances. changelog: Internal, Redis, Manage total connections to redis.
[skip changelog]
* security_code -> one_time_code Update translation keys that include `security_code` in their name to now say `one_time_code` to be more consistent with new wording. [skip changelog] * Fix click_send_security_code helper * click_send_security_code -> click_send_one_time_code Lots of references to `security_code` in specs that can be updated.
* Remove unused PasswordToggle React component [skip changelog] * Remove unused TextInput component
* Add background jobs command to README * Document async flag * [skip changelog] * Add note about Procfile * Link to Procfile as example * Explain that make run runs the Procfile
[skip changelog]
- Via ConnectionPool::Wrapper which may be slightly slower [skip changelog]
[skip changelog]
Hypothesis: creating new clients as often as we does makes too many IAM metadata requests, so this cuts down on that * Add comment on eager vs lazy * Make FakeConnectionPool more generic [skip changelog]
Before: three classes that did almost the same things: - Pii::SessionStore - X509::SessionStore - OutOfBandSessionAccessor After: just one class, OutOfBandSessionAccessor * Update spots to use new interface * Memoize session_data to save network requests * Optionally share session accessor in id_token + userinfo presenter * Save another allocation [skip changelog]
…entity Proofing Process (4 of 4) (#7176) * Add an informative comment changelog: Upcoming Features, Inherited Proofing, LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (4 of 4) * Refactors to allow SessionsController to handle IP Inherited Proofing (IP) session cleanup, analytics logging and redirect to the IP url when the user decides to "start over". * Add a route specific to inherited proofing Not necessary, but for consistency; we're pointing to the existing SessionsController. * Reinstate the "start over" cancellation button * Add cancel link on "Retrieving your info" view * Add devise controller helper to get spec to pass * Remove unnecessary includes * Refactor SessionController specs In prep for Inherited Proofing test additions. - Add SessionController specs for Inherited Proofing * Remove unnecessary return * Add comments for analytics So that when the card gets worked on, these areas can be identified and analytics applied. * Add feature specs Test cancel from all Inherited Proofing views, all cancellation scenarios: "Start over" "No, go back" "Exit Login.gov" Need to revisit cancellations from the :verify_waiting step; see notes in the spec file. * Patch to VAIP sessions controller changes (#7269) * Inline mixins to make the PR diff smaller and easier to understand * Inline shared examples that are only used once (not shared) * Remove unused shared example * Remove line length override and fix errors * fix typo * Reorganize SessionsController clean up code * Remove skipped specs per PR feedback * Clean up sone unnecessary/redundant mocks/vars * Remove redundant js enable on tests * Make regexp to check rails paths more concise * Remove regex when checking current_path * Remove proofing-specific tests * Fix rubocop errors * Move tests inline * Tidy up session mock Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
…#7287) * Update ARIA label for FileInput component When FileInput does not have a file added to it, ensure ARIA label includes the prompt to drag + drop a file. User testing found this was needed, as JAWS does not automatically read `aria-describedby` by default (it requires extra interaction). changelog: Improvements, Accessibility, Improve document upload screen reader text * Update tests * Remove stray comments
changelog: Internal, Dependencies, Update dependencies to resolve security advisories
changelog: Internal, Database, Create smaller user_id index on email_addresses
* display only failed because there are too many to render [skip changelog]
* "Get another code" -> "Send another code" Update language on the resend OTP button, aiming for better consistency across screens. [skip changelog] * get_another_code -> send_another_code Update translation keys to match new English phrasing
…th disavowal (#7301) * Refactor Event creation to avoid two DB writes when creating Event with disavowal changelog: Internal, Database, Refactor Event creation to avoid two DB writes when creating Event with disavowal * Update app/services/user_event_creator.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/user_event_creator.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update app/services/user_event_creator.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
requested review from
aduth,
henrydrichardson,
jskinne3,
matthinz,
n1zyy and
zachmargolis
zachmargolis
approved these changes
Nov 7, 2022
Comment on lines
-52
to
+55
| expires_in: Pii::SessionStore.new(identity.rails_session_id).ttl, | ||
| id_token: IdTokenBuilder.new(identity: identity, code: code).id_token, | ||
| expires_in: id_token_builder.ttl, | ||
| id_token: id_token_builder.id_token, |
Contributor
There was a problem hiding this comment.
extremely hyped for this optimization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements
Internal
Upcoming Features