Merged
Conversation
zachmargolis
approved these changes
Nov 4, 2022
Contributor
There was a problem hiding this comment.
IMO I don't think the change is big enough to merit renaming the key? But also fine to change it too
Contributor
Author
There was a problem hiding this comment.
Yeah, I'm not sure where that line is.
Update language on the resend OTP button, aiming for better consistency across screens. [skip changelog]
Update translation keys to match new English phrasing
matthinz
force-pushed
the
matthinz/lg-7717-security-code-update-2
branch
from
6dd66c7 to
9ab73d7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7717
🛠 Summary of changes
This is a follow-on from #7276. There was an additional language change that was missed in the initial translations doc. The "Get another code" button now reads "Send another code". I also updated the key names in the translation file from
get_another_codetosend_another_codeto keep them consistent.There is some additional context in the Slack Acceptance thread for LG-7717.
👀 Screenshots
🚀 Notes for Deployment
N/A