Conversation
gangelo
added
the
inherited proofing
gangelo
force-pushed
the
lg-7446-create-cancel-links-4-of-n
branch
from
83cae32 to
c783da9
Compare
gangelo
changed the title
gangelo
force-pushed
the
lg-7446-create-cancel-links-4-of-n
branch
11 times, most recently
from
68a228a to
62c72c3
Compare
gangelo
commented
Oct 26, 2022
gangelo
commented
Oct 26, 2022
gangelo
force-pushed
the
lg-7446-create-cancel-links-4-of-n
branch
5 times, most recently
from
cc4a58f to
b0acec5
Compare
changelog: Upcoming Features, Inherited Proofing, LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (4 of 4)
gangelo
force-pushed
the
lg-7446-create-cancel-links-4-of-n
branch
3 times, most recently
from
2a2e0e7 to
2431eb7
Compare
In prep for Inherited Proofing test additions. - Add SessionController specs for Inherited Proofing
So that when the card gets worked on, these areas can be identified and analytics applied.
Test cancel from all Inherited Proofing views, all cancellation scenarios: "Start over" "No, go back" "Exit Login.gov" Need to revisit cancellations from the :verify_waiting step; see notes in the spec file.
gangelo
force-pushed
the
lg-7446-create-cancel-links-4-of-n
branch
from
2431eb7 to
f5a0957
Compare
* Inline mixins to make the PR diff smaller and easier to understand * Inline shared examples that are only used once (not shared) * Remove unused shared example * Remove line length override and fix errors * fix typo
aduth
reviewed
Nov 3, 2022
spec/features/idv/inherited_proofing/inherited_proofing_cancel_spec.rb
Outdated
Show resolved
Hide resolved
spec/features/idv/inherited_proofing/inherited_proofing_cancel_spec.rb
Outdated
Show resolved
Hide resolved
spec/features/idv/inherited_proofing/inherited_proofing_cancel_spec.rb
Outdated
Show resolved
Hide resolved
aduth
approved these changes
Nov 4, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Couple minor comments, but otherwise LGTM 👍
aduth
reviewed
Nov 4, 2022
aduth
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See also PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)
See also PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (2 of n)
See also PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (3 of n)
🎫 Ticket
LG-7446
🛠 Summary of changes
NOTE: This is feature branch 4 of what will most likely be the 4th and final feature branch for this card.
In this feature branch:
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
👀 Screenshots
Before:
[Before image with no cancel link](https://user-images.githubusercontent.com/346917/198051609-541ad59d-6c4a-4931-b9bd-27c3f0fead76.png)After:
[After image with cancel link](https://user-images.githubusercontent.com/346917/198051002-0cb0aeb6-1a57-41f9-962d-6ce23a1434b1.png)🚀 Notes for Deployment
See PR LG-7446 Create "Cancel" Links and Supporting Cancellation Code for Identity Proofing Process (1 of n)