Conversation
zachmargolis
reviewed
Nov 3, 2022
README.md
Outdated
|
|
||
| ### Running jobs | ||
|
|
||
| We run background jobs / workers with ActiveJob and GoodJob: `bundle exec good_job start` |
Contributor
There was a problem hiding this comment.
maybe comment that locally this is in the Procfile too?
Contributor
Author
There was a problem hiding this comment.
Meaning that good_job does not have to be started manually locally? Because the Procfile is executed in the local dev environment?
Contributor
There was a problem hiding this comment.
yes both of those and also "here's an example in this repo of us using that"
Contributor
There was a problem hiding this comment.
and to further connect, since we typically develop via make run which runs the Procfile, that's why we don't need to separately run this when developing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
Need for documented knowledge discovered during
#login-situation-practice🛠 Summary of changes
Add good_job command to the README
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
bundle exec good_job startand ensure it starts jobs