Use a connection pool for redis-session-store#7289
Merged
zachmargolis merged 1 commit intomainfrom Nov 4, 2022
Merged
Conversation
Contributor
zachmargolis
commented
Nov 3, 2022
zachmargolis
commented
- Via ConnectionPool::Wrapper which may be slightly slower
- Via ConnectionPool::Wrapper which may be slightly slower [skip changelog]
zachmargolis
requested review from
henrydrichardson,
mitchellhenke and
timothy-spencer
zachmargolis
commented
Nov 3, 2022
| ) | ||
| end | ||
|
|
||
| REDIS_SESSION_POOL_WRAPPER = ConnectionPool::Wrapper.new( |
Contributor
Author
There was a problem hiding this comment.
I was on the fence about defining this here vs in session_store.rb
Pros:
- it's a consistent spot we define all our pools
Cons:
- relies on alphabetical ordering of initializers
Contributor
There was a problem hiding this comment.
I kinda like it being in session_store.rb, because it keeps all the session_store stuff in one place, but I don't feel strongly about that.
Contributor
Author
There was a problem hiding this comment.
That's true! But as a counterpoint, we missed one of our redis connection pools in this other PR because it wasn't defined in the same place: #7283 (comment)
zachmargolis
commented
Nov 3, 2022
|
|
||
| key_prefix: "#{IdentityConfig.store.domain_name}:session:", | ||
| url: IdentityConfig.store.redis_url, | ||
| client: REDIS_SESSION_POOL_WRAPPER, |
Contributor
Author
There was a problem hiding this comment.
next steps: fork session store gem to be able to use a connection pool directly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.