Remove unused PasswordToggle React component#7278
Merged
Conversation
[skip changelog]
aduth
commented
Nov 3, 2022
zachmargolis
approved these changes
Nov 3, 2022
allthesignals
added a commit
that referenced
this pull request
Nov 16, 2022
This reverts commit 09d0227.
allthesignals
added a commit
that referenced
this pull request
Nov 22, 2022
This reverts commit 09d0227.
allthesignals
added a commit
that referenced
this pull request
Dec 1, 2022
…on search (#7385) * Add address search component and relay results to USPS search * Revert "Remove unused PasswordToggle React component (#7278)" This reverts commit 09d0227. * Shape the address search results into expected shape for querying USPS * changelog: Improvements, In-Person Proofing, AddressSearch component * Extract request into separate package; set types * Track whether a search has been performed once. Show message on init * Todo tests added; request is more flexible for plain get requests * Update app/javascript/packages/request/index.ts Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update app/javascript/packages/request/README.md Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Infer initial search from presence of foundAddress * Drop unused helper func * Rename to something more specific to the effect itself * Hide AddressSearch implement behind feature flag * Add type def * Update app/javascript/packages/document-capture/components/in-person-location-step.tsx Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Include search results in address search component for testing * Use window.fetch so it’s stubbable * Remove prod-facing markup in favor of AddressSearch component * Correct place to include header * Remove styling and UX-specific work until ready... * Use snake_case for data * Minimal test to ensure happy path * Failing test * Add types for onChange signature * Add passing test for request lib * Fill out the rest of the tests * Add polyfill for Response * Refactor csrf to be injected another way * Extract feature flag into new, IPP-specific Context * Refactor to use index syntax * Move Response polyfil to spec helper * Add explicit assertion on window.fetch being called * React isn’t used here * No JSX, use TS * Use memoization correctly * Update app/javascript/packages/request/index.ts Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Test when CSRF is explicitly false * Try moving this up * Rework approach to import * Reverse render order * Dropping this for now because of conflict with other type definitions Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Removes the
<PasswordToggle />React component implementation, which is now unused after #7051.This will also help simplify changes for upcoming work around LG-7947, as we will need to make changes to common password toggle behaviors.