Adjustable Redis Connection Pooling#7283
Merged
henrydrichardson merged 1 commit intomainfrom Nov 3, 2022
Merged
Conversation
**Why**: - Adding the configuration parameters `redis_pool_size` and `redis_throttle_pool_size` allows us to limit, or increase, the number of connections to our redis instances. changelog: Internal, Redis, Manage total connections to redis.
henrydrichardson
requested review from
jgrevich,
mitchellhenke and
timothy-spencer
zachmargolis
approved these changes
Nov 3, 2022
| end | ||
|
|
||
| REDIS_THROTTLE_POOL = ConnectionPool.new(size: 5) do | ||
| REDIS_THROTTLE_POOL = ConnectionPool.new(size: IdentityConfig.store.redis_throttle_pool_size) do |
Contributor
There was a problem hiding this comment.
looks like we initialize the attempts API redis outside of this file:
identity-idp/app/services/irs_attempts_api/redis_client.rb
Lines 3 to 9 in 34f0bcc
Maybe if not for this PR, but could we follow up and add a config for it too, maybe even move it inside this file as a constant instead of a class member there?
This was referenced Nov 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://github.com/18F/identity-devops/issues/5429
🛠 Summary of changes
This PR enables adjustable connection pool sizes to redis instances.