Skip to content

OTP language update#7276

Merged
matthinz merged 2 commits intomainfrom
matthinz/lg-7717-otp-language-update
Nov 3, 2022
Merged

OTP language update#7276
matthinz merged 2 commits intomainfrom
matthinz/lg-7717-otp-language-update

Conversation

@matthinz
Copy link
Contributor

@matthinz matthinz commented Nov 2, 2022

🎫 Ticket

LG-7717

🛠 Summary of changes

Update "Enter your security code" screen to use new "one-time code" wording.

👀 Screenshots

If relevant, include a screenshot or screen capture of the changes.

Before After
English Screen Shot 2022-11-02 at 4 48 42 PM Screen Shot 2022-11-02 at 4 49 21 PM
Spanish Screen Shot 2022-11-02 at 4 48 49 PM Screen Shot 2022-11-02 at 4 49 27 PM
French Screen Shot 2022-11-02 at 4 48 56 PM Screen Shot 2022-11-02 at 4 49 31 PM

🚀 Notes for Deployment

N/A

Update language on OTP entry screen to reflect user testing results ("one-time code" rather than "security code").

For LG-7177

[skip changelog]
@matthinz matthinz requested a review from a team November 2, 2022 23:55
Copy link
Contributor

@theabrad theabrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matthinz matthinz merged commit 34f0bcc into main Nov 3, 2022
@matthinz matthinz deleted the matthinz/lg-7717-otp-language-update branch November 3, 2022 16:19
backup_code: Código de seguridad
# removed "security code" form labels as they trigger ios credit card reader
code: Código de un solo uso
code: Código único
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This string is used on the IAL1 (authentication) MFA pages, which weren't included in the pull request screenshots.

<%= label_tag :code, t('forms.two_factor.code'), class: 'display-block text-bold' %>

<%= label_tag :code, t('forms.two_factor.code'), class: 'display-block text-bold' %>

I think we want to be consistent here (related ticket LG-7932), so maybe not a problem, but flagging in case it wasn't intentional.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I believe the intention is to update language throughout.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mentioned this to the team in Slack and there don't seem to be any concerns, so should be good! (And I agree with being consistent in the language)

sms:
confirm_code_html: Need another code? %{resend_code_link}. Message rates may apply.
number_message_html: We sent a security code to %{number}. This code will expire
number_message_html: We sent a one-time code to %{number}. This code will expire
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment, reused in IAL1 (authentication).

def phone_number_message
t(
"instructions.mfa.#{otp_delivery_preference}.number_message_html",
number: content_tag(:strong, phone_number),
expiration: TwoFactorAuthenticatable::DIRECT_OTP_VALID_FOR_MINUTES,
)
end

cancelled: Identity verification is cancelled
come_back_soon: Come back soon
enter_security_code: Enter your security code
enter_security_code: Enter your one-time code
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're changing the text from "security code" to "one-time code", I think it'd be clearer if we updated the key accordingly.

Suggested change
enter_security_code: Enter your one-time code
enter_one_time_code: Enter your one-time code

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I hit merge too eagerly. I agree with this & will follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants