Adds attempts:enable_for_sinatra and fix minor breakage

[n1zyy]

🎫 Ticket

None. This is whim.

🛠 Summary of changes

• Fixes a small bug breaking rake attempts:check_enabled
• Adds rake attempts:enable_for_sinatra task, to make life easier

📜 Testing Plan

$ be rake attempts:check_enabled
✅ Feature flag is enabled
❌ FAILED: Run rake attempts:enable_for_sinatra
✅ abc123 set as auth token
✅ 'keys/attempts_api_private_key.key' exists for decrypting events
Remember to restart Rails after updating application.yml.default!

$ be rake attempts:enable_for_sinatra

$ be rake attempts:check_enabled
✅ Feature flag is enabled
✅ Sinatra app SP has irs_attempts_api_enabled=true
✅ abc123 set as auth token
✅ 'keys/attempts_api_private_key.key' exists for decrypting events

🚀 Notes for Deployment

N/A - This should not be used in prod.

[n1zyy]

This was set at the class level earlier but Zach (rightly) pulled some of it out since it was spamming rake output in prod: e82e728

We expected auth_token and private_key_path to be defined here. I'm duplicating them, and keeping the puts rather than adding a separate check. I don't think we need to worry about DRYing this up further.

[zachmargolis]

whoops great catch, thanks

[n1zyy]

Since we're already checking this and telling you if it's wrong, let's just offer to fix it here, rather than making the user go off to the rails console.

I briefly debated adding a check so this would refuse to run in prod, but (1) you shouldn't run random rake tasks in prod, (2) there probably isn't an actual SP named "Example Sinatra App" in prod, and (3) if there is, someone running this probably actually intends to enable it? 🤷 Happy to add a check if people believe it's warranted.

Going in the other direction, we could make check_enabled just fix this for you immediately, but none of the others can be done that way so it seems best to stay consistent.

[zachmargolis]

I'd consider maybe making the friendly name (or even issuer?) an argument so we ca call rake enable_attempts_api ISSUER=ABCDEF

[n1zyy]

That'd be easy enough to implement, but the intent here was just for localhost use with the default Sinatra app. I think if people are going to go edit other providers they're probably better off using the Rails console.

[Rwolfe-Nava]

Thank you for doing this!