Merged
Conversation
**Why**: The job uses the passed date for the reporting range, so it should correspond to the date used in stubbing data, like what's done in other test cases in the file. [skip changelog]
* Upgrade JSDOM * Upgrade devDependencies * changelog: Internal, Dependencies, Upgrade development dependencies
changelog: Bug Fixes, Identity Verification, Fix 500 error when displaying session error
* Expect address2 to be missing * Stop inheriting proofing base class * Simplify described class initialization in test * Replace `#proof` implementation * Create `Proofing::Aamva::ResultWithException` * Use Aamva verification request class * Pass expected arguments * VerificationRequest expects an Aamva::Applicant instance * Scope a level higher * Indent nested arguments * Scope locally * Expose class method vendor_name * Replace `#proof` with Base implementation `ProofingSpec#proof` only fails now * Restore hash argument * Expose previously assigned instance variable values * Convert class methods to private * cleanup the proofer and start on tests * cleanup aamva proofer spec * get a result class started * Put the result to work * a little more on the result * Assign aamva result to aamva stage in test * Expect Aamva proofer to return Aamva result * Expect a verification response object * Indent long lines * Remove unneeded requires * Add more tests * More tests * get the resulotion proofing job green * cleanup state id mock proofer * [skip changelog] * delint and cleanup * Consolidate to_sym calls * Test verified attributes * Consolidate address attributes * Test verified attributes on success and missing * Verify attributes, including address, from results * Format * do not really need this * [skip changelog] * Test for verified attributes in resolution proofing job spec * Strip out `address2` from verified attributes * Format array literal Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov>
* changelog: Internal, Rate Limit, Add rate limit for email registration requests * add non-US languages to sign in path rate limits * add /en paths
[skip changelog]
changelog: Internal, Attempts API, Standardize events
* Work in progress * Remove more * Removing old spec * Empty commit for changelog changelog: Internal, Code Removal, Removing FSMv2 React * Removing deprecated redirect check changelog: Internal, Code Removal, Removing FSMv2 React * Removing stale references to idv_app_path changelog: Internal, Code Cleanup, removing FSMv2 React code * Removing more outdated tests changelog: Internal, Code Cleanup, removing FSMv2 React code * Fixing lints changelog: Internal, Code Cleanup, removing FSMv2 React code * Update spec/features/idv/steps/review_step_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update spec/features/accessibility/idv_pages_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update spec/features/accessibility/idv_pages_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update spec/features/accessibility/idv_pages_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Removing stale dependencies from js verify-flow changelog: Internal, Code Cleanup, removing FSMv2 React code * Removing unused react components changelog: Internal, Code Cleanup, removing FSMv2 React code Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* handle StandardError without response changelog: Bug Fixes, In-person proofing, Improve job error handling * write repetitive tests for faraday errors * dry up tests with shared examples * change expected message for parsing error * changelog: Internal, In-person proofing, add tests for faraday errors * rewrite parsing error message * refactor tests * revert changes to usps proofing results job Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
…s an exception (#7074) changelog: Bug Fixes, Identity Verification, Fix undefined method transaction_id when LexisNexis PhoneFinder raises an exception
changelog: Internal, Documentation, Improve accuracy of frontend dependencies documentation
* Upgrade rubocop-performance changelog: Internal, Dependencies, Upgrade rubocop-performance * fix violations from new rubocop rule
…7063) * Support AAL2 phishing-resistant and PIV/CAC authentication contexts changelog: Improvements, Authentication, Support AAL2 phishing-resistant and PIV/CAC authentication contexts
We had a nil check in here for when the instant verify errors was nil, but not for when 'Items' was nil. This commit adds that protection [skip changelog]
mitchellhenke
approved these changes
Oct 4, 2022
Contributor
mitchellhenke
left a comment
mitchellhenke
left a comment
There was a problem hiding this comment.
Could be RC 215 if we want?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.