Merged
Conversation
aduth
commented
Sep 30, 2022
| Object.assign(global, windowGlobals); | ||
| global.window.fetch = () => Promise.reject(new Error('Fetch must be stubbed')); | ||
| global.window.crypto = webcrypto; | ||
| Object.defineProperty(global.window, 'crypto', { value: webcrypto }); |
Contributor
Author
There was a problem hiding this comment.
JSDOM became upset with this after the upgrade:
TypeError: Cannot set property crypto of #<Window> which has only a getter
mitchellhenke
approved these changes
Oct 3, 2022
1 task
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Upgrade JSDOM * Upgrade devDependencies * changelog: Internal, Dependencies, Upgrade development dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Upgrades most development JavaScript
devDependencies, with a couple exceptions:@testing-library/domhas some challenging breaking changes to sort through, which I will plan to address separatelySince
devDependenciesare largely limited to TypeScript and testing-related tools, these upgrades should be relatively safe assuming all existing tests pass.📜 Testing Plan
npx npm-check-updates --dep dev(React related dependencies and@testing-library/dom)