Fix undefined method transaction_id when LexisNexis PhoneFinder raises an exception#7074
Merged
mitchellhenke merged 1 commit intomainfrom Oct 4, 2022
Merged
Conversation
…s an exception changelog: Bug Fixes, Identity Verification, Fix undefined method transaction_id when LexisNexis PhoneFinder raises an exception
aduth
approved these changes
Oct 4, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
👍
Seems like something a base class would be well-suited to prevent against. It's difficult to tell what other classes might similarly be affected by this.
jmhooper
approved these changes
Oct 4, 2022
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
…s an exception (#7074) changelog: Bug Fixes, Identity Verification, Fix undefined method transaction_id when LexisNexis PhoneFinder raises an exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Based on a failed job from New Relic, it appears to be an unintentional breakage from #6920, which introduced a new shape for proofing results.
This PR adds a nil
transaction_idto ResultWithException so the results have closer behavior. TheAddressMockClientdoesn't use ResultWithException so it's not straightforward to test.