LG-7675: test for Faraday errors that have a nil response#7057
Merged
eileen-nava merged 10 commits intomainfrom Oct 4, 2022
Merged
LG-7675: test for Faraday errors that have a nil response#7057eileen-nava merged 10 commits intomainfrom
eileen-nava merged 10 commits intomainfrom
Conversation
changelog: Bug Fixes, In-person proofing, Improve job error handling
eileen-nava
changed the title
svalexander
reviewed
Sep 29, 2022
NavaTim
reviewed
Sep 30, 2022
aduth
reviewed
Sep 30, 2022
spec/support/usps_ipp_helper.rb
Outdated
| } | ||
| end | ||
|
|
||
| def stub_request_with_timeout_error(*_response) |
Contributor
There was a problem hiding this comment.
Couple thoughts:
- The other methods in this file are named specific to the endpoint they're stubbing, and I think we should follow that pattern here
- If we're not using the argument, do we need it? Many of the other methods here omit it, so I also don't see it being necessary purely out of consistency
Suggested change
| def stub_request_with_timeout_error(*_response) | |
| def stub_request_proofing_results_with_timeout_error |
Contributor
|
While we're here, should we fix up the additional changes recommended in the initial pull request? (e.g. https://github.com/18F/identity-idp/pull/7049/files#r983552375) |
Contributor
Author
I think the plan is to do that follow-up in ticket 7706. |
NavaTim
reviewed
Oct 3, 2022
NavaTim
approved these changes
Oct 3, 2022
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
* handle StandardError without response changelog: Bug Fixes, In-person proofing, Improve job error handling * write repetitive tests for faraday errors * dry up tests with shared examples * change expected message for parsing error * changelog: Internal, In-person proofing, add tests for faraday errors * rewrite parsing error message * refactor tests * revert changes to usps proofing results job Co-authored-by: Tomas Apodaca <thomas.apodaca@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7675
🛠 Summary of changes
(I merged Tomas's work from PR #7049 into my branch. Please let me know if I need to rebase or make other changes for the git history.)
I wrote tests to catch NewRelic errors, which Tomas had already fixed in PR #7049.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.