Merged
Conversation
changelog: Internal, Attempts API, Standardize events
ThatSpaceGuy
force-pushed
the
Event-Standardization-Work
branch
from
60b2885 to
b2299d0
Compare
Rwolfe-Nava
reviewed
Oct 3, 2022
| let(:personal_key_error) { { personal_key: [error_text] } } | ||
| let(:failure_properties) { { success: false, failure_reason: personal_key_error } } | ||
| let(:pii_like_keypaths_errors) { [[:errors, :personal_key], [:error_details, :personal_key]] } | ||
| let(:response_ok) { FormResponse.new(success: true, errors: {}) } |
Contributor
There was a problem hiding this comment.
I like the simplification that is done here. Great work 👍
n1zyy
approved these changes
Oct 3, 2022
| end | ||
|
|
||
| context 'with an invalid form' do | ||
| let(:bad_key) { 'baaad' } |
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
changelog: Internal, Attempts API, Standardize events
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardize the two undocumented Event names to be included in the Schema Doc.