Fix 500 error when displaying IDV session error#7073
Merged
mitchellhenke merged 1 commit intomainfrom Oct 3, 2022
Merged
Conversation
changelog: Bug Fixes, Identity Verification, Fix 500 error when displaying session error
mitchellhenke
force-pushed
the
mitchellhenke/idv-500-error
branch
from
55c48fb to
f4b6779
Compare
aduth
approved these changes
Oct 3, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
The controller itself does appear to be set up to handle a hybrid flow user (source), so I can see how it might be technically possible for user_session to be nil. However, all of the flows that I would expect to redirect to this page wouldn't occur as part of document capture, so I'm not sure how they'd actually get here. That being said, I think it makes sense to accommodate the technical possibility of a hybrid user here and the handling of it in the condition is what I'd expect 👍
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
changelog: Bug Fixes, Identity Verification, Fix 500 error when displaying session error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Came across a 500 in NewRelic caused by
user_sessionbeing nil. I'm not 100% sure this is the best way to fix it, but it is a way.