LG-7386: Remove code and tests associated with FSMv2#7051
Merged
Conversation
changelog: Internal, Code Removal, Removing FSMv2 React
changelog: Internal, Code Removal, Removing FSMv2 React
changelog: Internal, Code Cleanup, removing FSMv2 React code
changelog: Internal, Code Cleanup, removing FSMv2 React code
changelog: Internal, Code Cleanup, removing FSMv2 React code
aduth
reviewed
Sep 29, 2022
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
Contributor
Author
|
@aduth I've run through several of the idv flows in local testing and it seems to be working fine now. All tests are passing. I think I managed to scrape the last of the meat off the bone. |
aduth
changed the title
aduth
approved these changes
Sep 30, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
:pour-one-out: That's a lot of red!
LGTM! 👍
app/javascript/packages/verify-flow/steps/personal-key-confirm/personal-key-input.tsx
Show resolved
Hide resolved
app/javascript/packages/verify-flow/steps/personal-key/personal-key-step.tsx
Show resolved
Hide resolved
Comment on lines
359
to
360
| post '/verify/v2/document_capture' => 'verify/document_capture#create' | ||
| delete '/verify/v2/document_capture_errors' => 'verify/document_capture_errors#delete' |
Contributor
There was a problem hiding this comment.
As a follow-up, I think we should consider removing the /v2 from these paths to remove any traces of "FSMv2" naming conventions.
Contributor
Author
There was a problem hiding this comment.
Doing so directly wouldn't pose any issues, because all routes in rails are referred to by symbols right?
Contributor
There was a problem hiding this comment.
Yeah I think it should hopefully be a matter of updating these strings and nothing else.
added 2 commits
September 30, 2022 16:12
changelog: Internal, Code Cleanup, removing FSMv2 React code
changelog: Internal, Code Cleanup, removing FSMv2 React code
aduth
approved these changes
Oct 3, 2022
2 tasks
jskinne3
pushed a commit
that referenced
this pull request
Oct 12, 2022
* Work in progress * Remove more * Removing old spec * Empty commit for changelog changelog: Internal, Code Removal, Removing FSMv2 React * Removing deprecated redirect check changelog: Internal, Code Removal, Removing FSMv2 React * Removing stale references to idv_app_path changelog: Internal, Code Cleanup, removing FSMv2 React code * Removing more outdated tests changelog: Internal, Code Cleanup, removing FSMv2 React code * Fixing lints changelog: Internal, Code Cleanup, removing FSMv2 React code * Update spec/features/idv/steps/review_step_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update spec/features/accessibility/idv_pages_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update spec/features/accessibility/idv_pages_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Update spec/features/accessibility/idv_pages_spec.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * Removing stale dependencies from js verify-flow changelog: Internal, Code Cleanup, removing FSMv2 React code * Removing unused react components changelog: Internal, Code Cleanup, removing FSMv2 React code Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This was referenced Oct 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-7386
🛠 Summary of changes
This PR removes all code and tests associated with FSMv2, which itself involved moving certain pieces of the flow to the frontend (specifically, password re-entry and personal key steps).
This code was hidden behind a feature flag and not active in either dev or prod, so ideally the change should be invisible from a use standpoint.
📜 Testing Plan
Provide a checklist of steps to confirm the changes.
🚀 Notes for Deployment
No special notes