Support AAL2 phishing-resistant and PIV/CAC authentication contexts#7063
Support AAL2 phishing-resistant and PIV/CAC authentication contexts#7063mitchellhenke merged 9 commits intomainfrom
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/aal2-phishing-resistant
branch
from
1fd82b0 to
63684c9
Compare
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
Love where this is going - I think a little more test coverage for the backwards compatibility and to ensure we're returning the right AuthnContext in SAML and this should be good to go, but also defer to you 😄. THANK YOU!!!
There was a problem hiding this comment.
Looks like the last redirect to this was removed a couple years ago in #4014 so I deleted it
mitchellhenke
force-pushed
the
mitchellhenke/aal2-phishing-resistant
branch
2 times, most recently
from
2b073c8 to
ff06d1e
Compare
Had a go at adding the I also renamed some of the AAL3 pieces to be a bit more precise where we are explicitly still using AAL3 value (like for default_aal) |
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
A few minor comments but overall this looks/feels good to me. Not sure if you want another set of 👀 since I'm not quite as familiar with how the sp_session and mfa_policy get passed around, but from looking through the changes to the code everything made sense. Nice work, thank you!!
spec/features/openid_connect/phishing_resistant_required_spec.rb
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
nitpick: looks like we'll also have some I18n keys to rename as well 😭
There was a problem hiding this comment.
yeah, planning to tackle that in a future PR to keep the diff smaller here since it's already kind of unwieldy
spec/features/openid_connect/phishing_resistant_required_spec.rb
Outdated
Show resolved
Hide resolved
changelog: Improvements, Authentication, Support AAL2 phishing-resistant and PIV/CAC authentication contexts
mitchellhenke
force-pushed
the
mitchellhenke/aal2-phishing-resistant
branch
from
c570f1f to
4c1cf37
Compare
mitchellhenke
force-pushed
the
mitchellhenke/aal2-phishing-resistant
branch
from
4c1cf37 to
a585ea9
Compare
…7063) * Support AAL2 phishing-resistant and PIV/CAC authentication contexts changelog: Improvements, Authentication, Support AAL2 phishing-resistant and PIV/CAC authentication contexts
2 participants
🎫 Ticket
LG-5904
🛠 Summary of changes
TBD
📜 Testing Plan