Merged
Conversation
**Why:** This will allow partners to send back-channel SAML Logout requests instead of redirecting users as part of their logout flow. This controller action leverages the <SessionIndex> element of the SAML request to receive a user's agency UUID and uses the unique_session_id attribute to remotely log out a user from any active session.
…r adding file. (#5691) * LG-4575: accessible issue where no file selected still shows after selecting input * LG-4575: file update * LG-4575: update to just say captured image and update param name * update to return filename * LG-4575: add spec to ensure things are acting as expected * LG-4575: update * LG-4575: normalize yaml * LG-4575: doc auth captured form
**Why**: Because the inline configuration should only be used in cases where we're expecting a cop failure to otherwise occur.
…ic enumeration (#5706) * enumerate translations for 2FA selection * remove unused translations * enumerate translations for otp errors * remove unused translations * fully specify i18n key * render_views to cover backup codes error message * add more test coverage for selection presenter * make translation methods private
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Jonathan Hooper <jonathan.hooper@gsa.gov> Co-authored-by: Julia Elman <julia.elman@gsa.gov> Co-authored-by: Mitchell Henke <mitchell.henke@gsa.gov> **Why**: So that people can use their platform authenticator devices to access login.gov
…rs (#5708) LG-5325 Doc Auth: Added the ability to hide and show capture hints for the user depending on error returned from the backend. Also added field level errors where applicable for the user.
* Remove dates_billed from spreadsheet, not needed anymore * Add issuer_ial2_new_unique_users to combined reporting CSV
* fix regression * Update spec/views/accounts/connected_accounts/show.html.erb_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* LG-4682: Resolve confirmation step button scroll-to-top, role **Why**: Since "Print" and "Copy" are not navigable, they should not be rendered as links, since (a) this has the effect of scrolling the user to the top of the page when clicking the buttons and (b) they are announced to assistive technology as links. Since they behave as buttons, they should be rendered as such. * Reference super.call for ClipboardButtonComponent inherited render It might've been nice to keep the template and somehow reference the superclass's "call" result, but it wasn't immediately clear how to achieve this. * Avoid persisting initial clipboard text to instance **Why**: Generally, a custom element should be responsive to attribute changes (see "attributeChangedCallback"). It could be possible that someone would want to alter the clipboard text after the component has initialized. * Remove unused clipboard script from personal key page * Add spec to verify copied text
…r. (LG-5259) (#5719) * [Logging] Log an event when the user chooses to use a different number. (LG-5259) * use `step` instead of `location` * update spec
**Why:** We weren't testing this case explicitly and in the course of writing said test this refactor in the concern seemed cleaner than the original.
This commit uses [this reference](https://www.aamva.org/DLDV/) to add the following states since they are now supported: `{"KS", "NC", "OH", "OR", "TN"}`
* add specs * remove unused methods * Update spec/services/data_requests/write_user_events_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Update spec/services/data_requests/write_user_info_spec.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
**Why**: The user should not be on the completions screen if they don't have a service provider. This commit adds a before action to ensure that and removes the unused partial.
…acts (#5713) * Gitlab CI test coverage visualization * reorder test steps * store test coverage as CircleCI artifact * Update .circleci/config.yml Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
* Clean up Profile.proofing_components column encoding - The column is jsonb column, which ActiveRecord serializes already - We were basically double-encoding JSON objects - Adds a backfill job so we can clean up existing data and simplifying * Add logging * Save some ruby time by skipping null values Co-authored-by: Mitchell Henke <mitchellhenke@users.noreply.github.com>
* check for confirmed/unconfirmed availability in phone component * Add specs for supported delivery of confirmed/unconfirmed phones * Update app/components/phone_input_component.rb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * drop confirmed_phone parameter from idv phone forms Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
**Why**: - Because it's unnecessary JavaScript for a user to download and run - As part of transition to ClipboardButton component implementation
* also allow 666 prefix in mock proofer * Update config/locales/doc_auth/es.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* remove smart quotes from sent SMS messages * do not lint smart quotes in telephony files
* fix piv cac 500 on token * add regression spec
* Migrate ClipboardJS to ClipboardButtonComponent **Why**: - Better isolation of concerns - Fewer dependencies - Smaller bundle size - Polyfill-based implementation of ClipboardButtonComponent allows targeting native browser APIs with eventual removal of polyfill * Grant clipboardSanitizedWrite for Clipboard API write access
* Save proofing components in synchronous upload via JS
* Add a route for continuing user authorization confirmation **Why**: Previously this action was handled by the completions controller. This added some not-obvious coupling between the two. As a result, changes to the completions controller update action can have unintended consequences. This commit separates them out to hopefully simplify things. There is some logic in the completions controller to support both actions that we can also remove, but we will need to wait until this code is fully deployed before we pull that out.
**Why**: So that strings for all chunks are generated, even if not directly associated with an entry module.
This commit removes some unnecessary logic: - Removes ialmax method which was unused - Removes logic around whether the completions screen is required since now it is required in all contexts (ref: #5735)
**Why**: So that when a user is viewing the completions screen, we have a quicky way of knowing why they are there.
This commit adds a completions presenter which drops old view model style and moves some concerns, such as formatting PII, out of the controller
**Why**: Low timeouts consistently trigger a segfault in sassc, it happens even more often in Ruby 3 than it did before
Remove the `needs_completions_screen?` method in favor of just checking that `needs_completion_screen_reason` is not nil. Also update specs for the concern.
* do not install firefox or geckodriver in circle ci * move into common config alias
* Remove Gemfile-dev workflow * Fully alphabetize
- PR feedback from #5754
- Use CircleCI commands instead of YAML reference
* fix 500s when calling permit on nil * add spec
- PR feedback from #5760 - Move around call to #failure so it returns the right thing Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
* Add missing error messages to zxcvbn en.yml * Add missing translations for zxcvbn messages * Add additional missing translations
**Why**: To incorporate the bug fix which is currently preventing us from following our "Testing on a mobile device or in a virtual machine" documented development workflow. See: - https://rubyonrails.org/2021/12/15/Rails-6-0-4-4-and-6-1-4-4-have-been-released - https://github.com/18F/identity-idp#testing-on-a-mobile-device-or-in-a-virtual-machine
* Change useCookie hook to getter, avoid global override **Why**: As observed in #5747, the current logic can be prone to race conditions when multiple instances of the hook exist (mostly affecting specs). The implementation overriding the global was meant to support a use-case where a component would re-render in response to an external script modifying a cookie (e.g. Acuant SDK). Since our current sole usage is to get the cookie value at the time of a user initiating a capture, this live-updating support isn't necessary and unnecessarily complicates the implementation. * Add test case for multi-instance synced value * Implement cookie store as shared context
- Use floating point so we can be more precise - Separate different methods with different timeouts
Contributor
|
Will need to include #5788 here as well, to fix the build error. |
mitchellhenke
approved these changes
Jan 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.