LG-4575: accessiblility issue where no file selected still shows after adding file. #5691
Merged
LG-4575: accessiblility issue where no file selected still shows after adding file. #5691
Conversation
mdiarra3
commented
Dec 8, 2021
app/javascript/packages/document-capture/components/file-input.jsx
Outdated
Show resolved
Hide resolved
aduth
reviewed
Dec 10, 2021
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Could we add a spec here? Testing Library's getByLabelText will find elements by an aria-label, so it seems we could just use that to make sure we can find an element by the expected label.
app/javascript/packages/document-capture/components/file-input.jsx
Outdated
Show resolved
Hide resolved
app/javascript/packages/document-capture/components/file-input.jsx
Outdated
Show resolved
Hide resolved
aduth
reviewed
Dec 13, 2021
app/javascript/packages/document-capture/components/file-input.jsx
Outdated
Show resolved
Hide resolved
aduth
approved these changes
Dec 13, 2021
Contributor
There was a problem hiding this comment.
Works great on my computer. On my phone, it says "Captured image, no file selected, button". I tried playing with role as well to see if we could control this a bit better, but it didn't seem to have any effect.
Overall, I still think it's an improvement, since at least it mentions that there's a captured image. I'll leave it to you and the team whether we should invest more to look into this.
spec/javascripts/packages/document-capture/components/file-input-spec.jsx
Outdated
Show resolved
Hide resolved
nathanberg
added a commit
that referenced
this pull request
Dec 16, 2021
* main: (50 commits) LG-5325 Doc Auth: Error dependent hints and enhanced field level errors (#5708) Setup platform authentication (#5632) Remove unused i18n keys by replacing dynamic key generation with static enumeration (#5706) Configure and fix Rubocop redundant disabling/enabling (#5711) LG-4575: accessiblility issue where no file selected still shows after adding file. (#5691) Update rails to 6.1.4.3 (#5710) Add remote SAML Logout endpoint (#5676) Update "Frontend" CSS docs to reflect current approach (#5695) LG-3795 Harden CSP against JSONP endpoints on "safe" domains (#5704) LG-5261: Add cancel page logging to "Go Back" button (#5697) Add flow path to post doc capture submission events (LG-5257) (#5690) Log all vendor status in VendorStatus#track_event (#5703) Remove accept-terms-button in favor of ValidatedFieldComponent (#5687) Upgrade as many outdated Ruby dependencies as possible (LG-3828) (#5694) Remove BassCSS flex-object styling (#5702) Remove unused personal-key pattern validation message (#5701) Smoke tests in GitLab CI (#5699) Show a message in lower envs explaining how to use test SSNs (#5696) Remove temporary routes for SP redirects (#5679) LG-5262: Add logging to continue button on letter wait page (#5688) ...
jmhooper
pushed a commit
that referenced
this pull request
Dec 28, 2021
…r adding file. (#5691) * LG-4575: accessible issue where no file selected still shows after selecting input * LG-4575: file update * LG-4575: update to just say captured image and update param name * update to return filename * LG-4575: add spec to ensure things are acting as expected * LG-4575: update * LG-4575: normalize yaml * LG-4575: doc auth captured form
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
***Why? ***
Currently when a file is added to file upload. we still show "no file chosen."
Before:
After:
