LG-5477 Log total users counts w/breakdowns to analytics#5744
Merged
LG-5477 Log total users counts w/breakdowns to analytics#5744
Conversation
stevegsa
commented
Dec 30, 2021
| track_report_data_events(user_counts) | ||
| results = save_report(REPORT_NAME, user_counts.to_json, extension: 'json') | ||
|
|
||
| track_global_user_total_events |
Contributor
Author
There was a problem hiding this comment.
we can piggy back it here...it could be it's own job
Contributor
There was a problem hiding this comment.
the queries are completely independent of the ones for the s3 report right? seems better to be in its own job IMO
Contributor
Author
There was a problem hiding this comment.
my thinking on this was that these should eventually go into a report and logically this might be the one
zachmargolis
reviewed
Jan 4, 2022
| track_report_data_events(user_counts) | ||
| results = save_report(REPORT_NAME, user_counts.to_json, extension: 'json') | ||
|
|
||
| track_global_user_total_events |
Contributor
There was a problem hiding this comment.
the queries are completely independent of the ones for the s3 report right? seems better to be in its own job IMO
stevegsa
changed the title
aduth
reviewed
Jan 6, 2022
| end | ||
|
|
||
| def reports_logger | ||
| @reports_log ||= ActiveSupport::Logger.new(Rails.root.join('log', 'reports.log')) |
Contributor
There was a problem hiding this comment.
This fails with the changes in #5761, causing a build failure on main at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Log all JSON reports to analytics for time based reporting and visualization