Skip to content

Add remote SAML Logout endpoint#5676

Merged
orenyk merged 1 commit intomainfrom
oyk-backend-saml-logout
Dec 14, 2021
Merged

Add remote SAML Logout endpoint#5676
orenyk merged 1 commit intomainfrom
oyk-backend-saml-logout

Conversation

@orenyk
Copy link
Contributor

@orenyk orenyk commented Dec 7, 2021

Why: This will allow partners to send back-channel SAML Logout
requests instead of redirecting users as part of their logout flow. This
controller action leverages the <SessionIndex> element of the SAML
request to receive a user's agency UUID and uses the unique_session_id
attribute to remotely log out a user from any active session.

@orenyk orenyk requested a review from jmhooper December 7, 2021 04:57
@orenyk orenyk marked this pull request as draft December 7, 2021 04:57
@orenyk orenyk changed the title Add remote SAML Logout endpoint WIP: Add remote SAML Logout endpoint Dec 7, 2021
@zachmargolis
Copy link
Contributor

Is there a standard place in the SAML metadata endpoint for us to include this in?

@orenyk
Copy link
Contributor Author

orenyk commented Dec 7, 2021

@zachmargolis I think it would also be under SingleLogoutService (which we currently don't include anything for but it's not clear why it was removed - 18F/saml_idp#30)

@zachmargolis
Copy link
Contributor

@zachmargolis I think it would also be under SingleLogoutService (which we currently don't include anything for but it's not clear why it was removed - 18F/saml_idp#30)

That has two bindings, one for HTTP-POST and one for HTTP-Redirect. This seems like it would not redirect, so do we only binding to one of those?

@orenyk
Copy link
Contributor Author

orenyk commented Dec 7, 2021

@zachmargolis yeah we wouldn't list this one with a redirect binding

**Why:** This will allow partners to send back-channel SAML Logout
requests instead of redirecting users as part of their logout flow. This
controller action leverages the <SessionIndex> element of the SAML
request to receive a user's agency UUID and uses the unique_session_id
attribute to remotely log out a user from any active session.
@orenyk orenyk force-pushed the oyk-backend-saml-logout branch from f325159 to b156488 Compare December 14, 2021 19:51
@orenyk orenyk marked this pull request as ready for review December 14, 2021 19:51
@orenyk orenyk changed the title WIP: Add remote SAML Logout endpoint Add remote SAML Logout endpoint Dec 14, 2021
@orenyk orenyk merged commit 31c533f into main Dec 14, 2021
@orenyk orenyk deleted the oyk-backend-saml-logout branch December 14, 2021 20:06
nathanberg added a commit that referenced this pull request Dec 16, 2021
* main: (50 commits)
  LG-5325 Doc Auth: Error dependent hints and enhanced field level errors (#5708)
  Setup platform authentication (#5632)
  Remove unused i18n keys by replacing dynamic key generation with static enumeration (#5706)
  Configure and fix Rubocop redundant disabling/enabling (#5711)
  LG-4575: accessiblility issue where no file selected still shows after adding file.  (#5691)
  Update rails to 6.1.4.3 (#5710)
  Add remote SAML Logout endpoint (#5676)
  Update "Frontend" CSS docs to reflect current approach (#5695)
  LG-3795 Harden CSP against JSONP endpoints on "safe" domains (#5704)
  LG-5261: Add cancel page logging to "Go Back" button (#5697)
  Add flow path to post doc capture submission events (LG-5257) (#5690)
  Log all vendor status in VendorStatus#track_event (#5703)
  Remove accept-terms-button in favor of ValidatedFieldComponent (#5687)
  Upgrade as many outdated Ruby dependencies as possible (LG-3828) (#5694)
  Remove BassCSS flex-object styling (#5702)
  Remove unused personal-key pattern validation message (#5701)
  Smoke tests in GitLab CI (#5699)
  Show a message in lower envs explaining how to use test SSNs (#5696)
  Remove temporary routes for SP redirects (#5679)
  LG-5262: Add logging to continue button on letter wait page (#5688)
  ...
mitchellhenke pushed a commit that referenced this pull request Dec 16, 2021
**Why:** This will allow partners to send back-channel SAML Logout
requests instead of redirecting users as part of their logout flow. This
controller action leverages the <SessionIndex> element of the SAML
request to receive a user's agency UUID and uses the unique_session_id
attribute to remotely log out a user from any active session.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants