Increase rack timeout in development to fix assets locally#5765
Increase rack timeout in development to fix assets locally#5765zachmargolis merged 1 commit intomainfrom
Conversation
**Why**: Low timeouts consistently trigger a segfault in sassc, it happens even more often in Ruby 3 than it did before
| password_pepper: f22d4b2cafac9066fe2f4416f5b7a32c | ||
| piv_cac_verify_token_secret: ee7f20f44cdc2ba0c6830f70470d1d1d059e1279cdb58134db92b35947b1528ef5525ece5910cf4f2321ab989a618feea12ef95711dbc62b9601e8520a34ee12 | ||
| rails_mailer_previews_enabled: 'true' | ||
| rack_timeout_service_timeout_seconds: 9_999_999_999 |
There was a problem hiding this comment.
I think you want a string here. Also, we can probably make is something more reasonable, like 10 minutes
There was a problem hiding this comment.
it's valid YAML! and our config parser just calls Integer() on it anyways
require 'yaml'
YAML.load <<-STR
rack_timeout_service_timeout_seconds: 9_999_999_999
STR
=> {"rack_timeout_service_timeout_seconds"=>9999999999}
identity-idp/lib/identity_config.rb
Lines 18 to 20 in 0f018a5
There was a problem hiding this comment.
Ah sweet. There used to be something that yelled at you when you put non string values in here. Maybe that went away with Figaro.
There was a problem hiding this comment.
Yeah, it was a Figaro-ism because it also had to be able to write the value to the system environment variable
| password_pepper: f22d4b2cafac9066fe2f4416f5b7a32c | ||
| piv_cac_verify_token_secret: ee7f20f44cdc2ba0c6830f70470d1d1d059e1279cdb58134db92b35947b1528ef5525ece5910cf4f2321ab989a618feea12ef95711dbc62b9601e8520a34ee12 | ||
| rails_mailer_previews_enabled: 'true' | ||
| rack_timeout_service_timeout_seconds: 9_999_999_999 |
There was a problem hiding this comment.
do we need to add this to test as well?
There was a problem hiding this comment.
I figure the problem happened most often in development? But yeah I guess it wouldn't hurt to add to test... will follow up
Why: Low timeouts consistently trigger a segfault in
sassc, it happens even more often in Ruby 3 than it did
before