Skip to content

Increase rack timeout in development to fix assets locally#5765

Merged
zachmargolis merged 1 commit intomainfrom
margolis-development-timeout
Dec 30, 2021
Merged

Increase rack timeout in development to fix assets locally#5765
zachmargolis merged 1 commit intomainfrom
margolis-development-timeout

Conversation

@zachmargolis
Copy link
Contributor

Why: Low timeouts consistently trigger a segfault in
sassc, it happens even more often in Ruby 3 than it did
before

**Why**: Low timeouts consistently trigger a segfault in
sassc, it happens even more often in Ruby 3 than it did
before
password_pepper: f22d4b2cafac9066fe2f4416f5b7a32c
piv_cac_verify_token_secret: ee7f20f44cdc2ba0c6830f70470d1d1d059e1279cdb58134db92b35947b1528ef5525ece5910cf4f2321ab989a618feea12ef95711dbc62b9601e8520a34ee12
rails_mailer_previews_enabled: 'true'
rack_timeout_service_timeout_seconds: 9_999_999_999
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want a string here. Also, we can probably make is something more reasonable, like 10 minutes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's valid YAML! and our config parser just calls Integer() on it anyways

require 'yaml'
YAML.load <<-STR
rack_timeout_service_timeout_seconds: 9_999_999_999
STR
=> {"rack_timeout_service_timeout_seconds"=>9999999999}

integer: proc do |value|
Integer(value)
end,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sweet. There used to be something that yelled at you when you put non string values in here. Maybe that went away with Figaro.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it was a Figaro-ism because it also had to be able to write the value to the system environment variable

@zachmargolis zachmargolis merged commit 5e8f74c into main Dec 30, 2021
@zachmargolis zachmargolis deleted the margolis-development-timeout branch December 30, 2021 18:21
password_pepper: f22d4b2cafac9066fe2f4416f5b7a32c
piv_cac_verify_token_secret: ee7f20f44cdc2ba0c6830f70470d1d1d059e1279cdb58134db92b35947b1528ef5525ece5910cf4f2321ab989a618feea12ef95711dbc62b9601e8520a34ee12
rails_mailer_previews_enabled: 'true'
rack_timeout_service_timeout_seconds: 9_999_999_999
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to add this to test as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figure the problem happened most often in development? But yeah I guess it wouldn't hurt to add to test... will follow up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants