Also allow 666 prefix in mock proofer#5698
Merged
mitchellhenke merged 2 commits intomainfrom Dec 20, 2021
Merged
Conversation
mitchellhenke
force-pushed
the
mitchellhenke/test-ssns-part-two
branch
2 times, most recently
from
77c4a4c to
8f40c9d
Compare
aduth
reviewed
Dec 13, 2021
orenyk
approved these changes
Dec 13, 2021
Contributor
orenyk
left a comment
orenyk
left a comment
There was a problem hiding this comment.
One question re: tests, otherwise looks good to me!
Contributor
There was a problem hiding this comment.
question: were you still going to add tests for this?
Contributor
Author
There was a problem hiding this comment.
I was going to, but couldn't find an easy place to test it. It doesn't look like the mock proofers have direct specs, and they are only tested via other specs. We probably should though?
mitchellhenke
force-pushed
the
mitchellhenke/test-ssns-part-two
branch
from
0b1f7fd to
c426733
Compare
jmhooper
approved these changes
Dec 20, 2021
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
mitchellhenke
force-pushed
the
mitchellhenke/test-ssns-part-two
branch
from
c426733 to
8e4ff37
Compare
jmhooper
pushed a commit
that referenced
this pull request
Dec 28, 2021
* also allow 666 prefix in mock proofer * Update config/locales/doc_auth/es.yml Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the implementation for the notice going out to sandbox partners today. The dev docs notice is in GSA-TTS/identity-dev-docs#208 and this is a follow up to #5576
It should not be merged prior to Dec 20th