Merged
Conversation
Contributor
zachmargolis
commented
Jan 3, 2022
zachmargolis
commented
- PR feedback from Fix bug with IDV hybrid flow handoff after cancellation (LG-5367) #5760
- PR feedback from #5760 Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
mitchellhenke
approved these changes
Jan 3, 2022
aduth
approved these changes
Jan 3, 2022
Contributor
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Any thoughts about the other comment at #5760 (comment) ?
Co-authored-by: Andrew Duthie <aduth@users.noreply.github.com>
Contributor
Author
Yup, check out f4eb475 The regression specs pass! Huge simplification, thanks |
aduth
reviewed
Jan 3, 2022
|
|
||
| def render_document_capture_cancelled | ||
| failure(I18n.t('errors.doc_auth.document_capture_cancelled')) | ||
| mark_steps_incomplete |
Contributor
There was a problem hiding this comment.
Arguably we could remove link_sent from HYBRID_FLOW_STEPS since it's not having any effect here anyways, but I don't think it hurts anything to keep.
Contributor
Author
There was a problem hiding this comment.
thanks! I have no desire to touch this code any more than is absolutely needed, gonna leave as-is for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.