Move disposable email configs to application.yml#5754
Merged
zachmargolis merged 1 commit intomainfrom Dec 27, 2021
Merged
Conversation
pauldoomgov
approved these changes
Dec 27, 2021
Contributor
pauldoomgov
left a comment
pauldoomgov
left a comment
There was a problem hiding this comment.
Yes please! This is config stuff, and we should not advertise the blocked domains.
zachmargolis
force-pushed
the
margolis-email-domains-in-application-yml
branch
from
4b15abb to
4b2caf9
Compare
mitchellhenke
approved these changes
Dec 27, 2021
aduth
reviewed
Jan 3, 2022
| deleted_user_accounts_report_configs: '[]' | ||
| disable_email_sending: 'true' | ||
| disallow_all_web_crawlers: 'true' | ||
| disposable_email_services: '["courtsidemail.com","eyamail.com","fileright.net","immigrationdirect.com","kingfishmail.com","speedstermail.com","sprintpostmail.com","usimmigrationemail.com","firemailbox.club","safemail.icu","temp2-login.com","temp5-login.com","temp9-login.com","temp13-login.com"]' |
Contributor
There was a problem hiding this comment.
To @pauldoomgov's point, should we consider to empty this out in the default configuration and keep it only in the live production configuration?
peggles2
pushed a commit
that referenced
this pull request
Jan 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #5753