[Logging] Log an event when the user chooses to use a different number. (LG-5259)#5719
Merged
[Logging] Log an event when the user chooses to use a different number. (LG-5259)#5719
Conversation
aduth
reviewed
Dec 16, 2021
|
|
||
| def new | ||
| if params[:location] | ||
| analytics.track_event(Analytics::IDV_PHONE_USE_DIFFERENT, location: params[:location]) |
Contributor
There was a problem hiding this comment.
Elsewhere, we use "location" as a way to disambiguate different links within an individual step, whereas here it's a path. We also log "step" in a lot of cases too.
What do you think about logging step instead? Or something like from_step, if that's clearer?
There's a value in the view we use for cancel links:
Contributor
Author
There was a problem hiding this comment.
Yeah, I was going to ask about that ;-) updated in 76faec6
solipet
force-pushed
the
dprice-lg-5259-phone-logging
branch
from
336757a to
76faec6
Compare
aduth
approved these changes
Dec 16, 2021
| end | ||
|
|
||
| context 'when the user has chosen to use a different number' do | ||
| let(:step) { 'path_where_user_asked_to_use_different_number' } |
Contributor
There was a problem hiding this comment.
Nit: Not a path anymore.
Suggested change
| let(:step) { 'path_where_user_asked_to_use_different_number' } | |
| let(:step) { 'step_where_user_asked_to_use_different_number' } |
Contributor
Author
There was a problem hiding this comment.
yeah, I caught that, too! 😄
jmhooper
pushed a commit
that referenced
this pull request
Dec 28, 2021
…r. (LG-5259) (#5719) * [Logging] Log an event when the user chooses to use a different number. (LG-5259) * use `step` instead of `location` * update spec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently "use a different phone number" links on both the IAL2 phone OTP pages aren't logged at all. This PR adds a
locationparam to the link on each page with the path it is coming from, and if that location param is present, logs a new event.