Merged
Conversation
* Implement BaseComponent for per-component script packs **Why**: To give developers a simple way to write accompanying JavaScript for a ViewComponent, in a way which limits boilerplate and supports potential reuse for view components outside Rails. Also further reinforces the idea of components as self-contained units, limiting the amount of JavaScript rendered to a page to only that which is used in the page. * parentheses for lint appeasement * Try to improve test isolation for BaseComponent * Add feature spec coverage for toggled USA banner * Use view context to enqueue scripts * Add components to additional_paths Required for Babel to be used to transform source https://github.com/rails/webpacker/blob/e0c998e2aa7f096709eaa2a7f2d7e29d413abed3/package/rules/babel.js#L10 * Opt-in component scripts to type-checking * Abstract component script rendering Reduce tight coupling to Rails/Webpacker * Revert accordion script Until we can find a way to incorporate implicit dependency from accordion-like UI such as banner * Use sidecar_files API for loading adjacent scripts - No separate call to render_script required - Builds on existing ViewComponent behavior - Computed once as class variable - Memoize enqueue
…flow (#5490) * Allow supported international phone numbers for IAL2 hybrid flow **Why**: So that a user with an international phone number can complete the proofing process, since address verification can be completed via mailed code. * Fix PhoneForm#user_phone? equality check See: https://github.com/18F/identity-idp/pull/5490/files#r725313226 * Customize error message specific to deliverability failure * Fix YARDoc capitalization Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> * Set delivery methods default from argument See: #5490 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> * Raise error for unknown method supports See: #5490 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zbmargolis@gmail.com>
* Extract react-i18n package **Why**: To be able to support the use of React i18n functions outside the document-capture package (e.g. in the components package), and to better separate shared utilities and simplify the scope of the document-capture package. * Ignore strings in all spec or fixture files **Why**: Avoid tedium of adding exceptions for all test strings * eh, on second thought, exempt specific paths **why**: Some spec files may contain lingering references to unused or missing strings, which we'd want to be made aware of. The ones we don't care about are pretty isolated to these packages * Limit expect globals define to spec files **Why**: So that a developer who tries to use expect in application code will encounter a failed build
**Why**: Because I had mistakenly neglected to get these professionally translated as part of the work in #5300.
* LG-4944: track whether the user edits their address or not
- Include specs to make sure we implement them in the future
* Refactor ssn field to include example, capitalize 'E' in all languages * Address PR comments
* increase focus and outline offset; solid border when upload is successful; add checkmark * fix linter errors * update focus for file input box * Update app/assets/stylesheets/components/_file-input.scss Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> * refine focus for file input box for when a file is uploaded Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Re-translate strings
* Change %{app} => %{app_name} for consistency
Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* Extract PhoneInputComponent for reuse **Why**: Toward supporting LG-5193, to display an international phone input on the hybrid "Send Link" screen. * Remove redundant if conditions querySelectorAll always returns an array, which is truthy * Resolve type error on possibly-null input form * Flatten iti querying Only one per element, elements available from iti instance * Remove wrapper hide class **Why**: Not needed with no-js. Maybe helps make it be a bit more standalone, but still tied to USWDS. YAGNI for now * Localize accessible label for country code flag * Clean up code comments * Simplify condition codeWrapper not called in constructor * Set example number from intlTelInput utils More reliable than waiting on intlTelInput to set placeholder, e.g. in case of failed server-side validation where value is prepopulated, intlTelInput won't actually set the placeholder * Import intlTelInput from bare identifier Points to the same place: https://github.com/jackocnr/intl-tel-input/blob/fa983deab4d1a671e367c5d4585d7ed58f785932/index.js#L4 * Handle form validation with setCustomValidity * Move phone_code_label to components locale strings Because it's only used within the component * Configure global feature spec console log monitoring **Why**: So that it's less of a mystery when things break * Revert to "plain" custom element **Why**: Need to sort out conflicts with Webpack dynamic imports See: #5481 (comment) * Change PhoneInput rootNode type signature to Element More compatible with querySelector result * Update sign_in_spec for new phone input class names * Revert "Configure global feature spec console log monitoring" Address separately at: #5492 This reverts commit 631d27efd42b0e314cbc9de87844cf2d01e6b3ec. * Avoid within for select code assignment **Why**: Because it creates scoped variables which aren't accessible at time of assertions * Set custom validity on select input **Why**: Avoid conflicts with multiple custom validations on text input * Use simple_form_for for OTP delivery preference forms **Why**: Avoid conflicts of validation handling between form-validation and otp-delivery-preference * Add disabled states assertions to OTP specs **Why**: Regression spec for disabling submit on invalid phone numbers * Remove else branch of asset_host assignment **Why**: Hopefully fix issue with Webpacker root path being set with double leading slashes ("//packs-test") See: #5481 (review) * Revert "Revert to "plain" custom element" This reverts commit c655059eac6728bb344f749a1a3eccf6fc51f1a9. * Add regression assertions for example number text * Consolidate to single "country code" label See: - #5481 (comment) - https://gsa-tts.slack.com/archives/CNCGEHG1G/p1634063857008300 * Hide example number when JS disabled Because we don't set it, so it's more confusing to be visible * Fix ERB lint errors * Update translations
**Why**: JavaScript are always rendered last on the page, so at that point all markup we care about is already present. Benefits: - Marginally quicker time-to-initialize, since there would be a small delay between script execution and DOMContentLoaded - Reduce JavaScript bundle size - Fewer dependencies reduces maintenance burden
- Hopefully to fix "unknown relation good_jobs" error
**Why**: To bring consistency to how we present international phone number input fields, since we now support international numbers for the IAL2 hybrid flow.
…nd" to "Your picture is taken in a well-lit area with a plain background" (#5512)
**Why**: These styles are intended to override the default intl-tel-input relative-path, non-fingerprinted image path URL. Since the image is part of the Rails asset pipeline, it needs to be referenced with the image-url helper.
* LG-5040: refactor text field * add inline js * validation html * LG-5040: refactor text field * LG-5040: add inline validation * LG-5040: validation yaml fixes * LG-5040: updated inputs for inline-validation * LG-5040: leverage css more * LG-5040: fix linting issue * LG-5040: lint fixes * LG-5040: update spec to make sure its properly setting aria invalid propelry * LG-5040: clean up styling, remove error-state css class * LG-5040: lint fix * LG-5040: add validation to send link and verify account * LG-5040: madd spacing * LG-5040: update styling * LG-5040: add padding
…ested (LG-5219) (#5514) * add failing spec * check for reset profile * use route helpers instead of interpolation
**Why**: HTMLSelectElement#selectedOptions is not supported in Internet Explorer. See: https://developer.mozilla.org/en-US/docs/Web/API/HTMLSelectElement/selectedOptions#browser_compatibility
* add failing spec * fix nice device name with no OS version
* schedule GPO cron job to run before 6AM Eastern time in both DST and Standard * more specific file name * raise error after sending error to new relic * Update config/initializers/job_configurations.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
Resolves LG-5267
- Exception class objects were begin JSON serialized as "{}" in the logs
Resolves LG-5273 This was causing our config seeders to fail due to an edge case where an integration was moved to a different account.
orenyk
approved these changes
Oct 20, 2021
* fix header size on account reset request page * Update app/views/account_reset/request/show.html.erb Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
aduth
approved these changes
Oct 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.