Merged
Conversation
mitchellhenke
requested review from
jmhooper,
juliasolorzano,
pauldoomgov and
zachmargolis
jmhooper
approved these changes
Oct 19, 2021
mitchellhenke
force-pushed
the
mitchellhenke/gpo-stuff
branch
from
b2deb07 to
934818e
Compare
zachmargolis
approved these changes
Oct 19, 2021
| clear_confirmations(confirmations) | ||
| rescue StandardError => error | ||
| NewRelic::Agent.notice_error(error) | ||
| raise error |
Contributor
There was a problem hiding this comment.
Would the error still go to NewRelic if we removed the rescue? Since we have the GoodJob.on_thread_error go to NR already?
Contributor
Author
There was a problem hiding this comment.
I think so, but I'm not sure
Contributor
There was a problem hiding this comment.
🤷 for the time being probs safe to leave this in explicitly
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
mitchellhenke
pushed a commit
that referenced
this pull request
Oct 19, 2021
* schedule GPO cron job to run before 6AM Eastern time in both DST and Standard * more specific file name * raise error after sending error to new relic * Update config/initializers/job_configurations.rb Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com> Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We found a few issues with the GPO upload in the switch to workers. This PR aims to: