Merged
Conversation
aduth
approved these changes
Oct 18, 2021
| 'account.index.device', | ||
| browser: "#{browser.name} #{browser.version}", | ||
| os: "#{browser.platform.name} #{browser.platform.version.split('.').first}", | ||
| os: os, |
Contributor
There was a problem hiding this comment.
Could we do something like... ?
Suggested change
| os: os, | |
| os: [browser.platform.name, browser.platform.version&.split('.')&.first].compact.join(' '), |
Contributor
Author
There was a problem hiding this comment.
It would need the null-safe navigator, but otherwise yep
zachmargolis
approved these changes
Oct 18, 2021
Contributor
zachmargolis
left a comment
zachmargolis
left a comment
There was a problem hiding this comment.
I think technically these logic changes were from https://github.com/18F/identity-idp/pull/5489/files#diff-c9f51ebbfd2551776f99b17769a06e6a6ae22a090d8311551a1a922b7cb36eb8, but otherwise same same, good catch! Thanks for the good test case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #5491
It is possible we don't get a platform version, and it was leading to 500s: NR Link
This PR adds some checks around not attempting to split on
nil