LG-5193: Allow supported international phone numbers for IAL2 hybrid flow#5490
LG-5193: Allow supported international phone numbers for IAL2 hybrid flow#5490
Conversation
|
Definitely out of scope for this PR, but since we're in this area, I'd love for us to see if we can pick back up using an option to use a QR code for this handoff, old JIRA https://cm-jira.usa.gov/browse/LG-2854 |
Yeah, I can't see me getting to it as part of this work, but I'll surface with the team to see if we could prioritize this, since I agree it could make the flow simpler, and also give some users an option to proof with their phone who might not otherwise have the ability (no cell service, country which can't receive SMS, etc). |
|
I noticed we don't show error messages for form validation issues on the IAL2 phone step, which I tracked as a bug at LG-5225. I did verify with |
app/forms/idv/phone_form.rb
Outdated
There was a problem hiding this comment.
I would consider moving the default value to the args:
| def initialize(user:, previous_params:, allowed_countries: nil, delivery_methods: nil) | |
| previous_params ||= {} | |
| @user = user | |
| @allowed_countries = allowed_countries | |
| @delivery_methods = delivery_methods || ALL_DELIVERY_METHODS | |
| def initialize(user:, previous_params:, allowed_countries: ALL_DELIVERY_METHODS, delivery_methods: nil) | |
| previous_params ||= {} | |
| @user = user | |
| @allowed_countries = allowed_countries | |
| @delivery_methods = delivery_methods |
There was a problem hiding this comment.
Yeah, makes sense. Admittedly I'd considered this, then out of convenience (read: laziness) for test stubbing opted to move the defaulting to the body. In retrospect, I agree it's better as a default argument.
**Why**: So that a user with an international phone number can complete the proofing process, since address verification can be completed via mailed code.
Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
See: #5490 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
See: #5490 (comment) Co-Authored-By: Zach Margolis <zbmargolis@gmail.com>
827a861 to
78d5530
Compare
Why: So that a user with an international phone number can complete the proofing process, since address verification can be completed via mailed code.